Skip to content

Commit 3f49aa9

Browse files
authored
fix(svelte): unmount islands properly on navigation (#8448)
1 parent f3f62a5 commit 3f49aa9

2 files changed

Lines changed: 8 additions & 3 deletions

File tree

.changeset/sweet-sheep-sell.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@astrojs/svelte': patch
3+
---
4+
5+
Fix potential memory leak when component is unmounted

packages/integrations/svelte/client.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ const noop = () => {};
33
let originalConsoleWarning;
44
let consoleFilterRefs = 0;
55

6-
export default (target) => {
6+
export default (element) => {
77
return (Component, props, slotted, { client }) => {
8-
if (!target.hasAttribute('ssr')) return;
8+
if (!element.hasAttribute('ssr')) return;
99
const slots = {};
1010
for (const [key, value] of Object.entries(slotted)) {
1111
slots[key] = createSlotDefinition(key, value);
@@ -15,7 +15,7 @@ export default (target) => {
1515
if (import.meta.env.DEV) useConsoleFilter();
1616

1717
const component = new Component({
18-
target,
18+
target: element,
1919
props: {
2020
...props,
2121
$$slots: slots,

0 commit comments

Comments
 (0)