Setup Script#17
Merged
brettstack merged 8 commits intomasterfrom Jun 9, 2020
Merged
Conversation
brettstack
suggested changes
Jun 9, 2020
Contributor
brettstack
left a comment
brettstack
left a comment
There was a problem hiding this comment.
Nice! Main issue is the hardcoded iamRoleStatementsName. Other than that, looks good!
denisse-dev
approved these changes
Jun 9, 2020
NellyGzzA
approved these changes
Jun 9, 2020
Contributor
NellyGzzA
left a comment
NellyGzzA
left a comment
There was a problem hiding this comment.
just a small comment, overall lgtm :)
| const APIPath = 'packages/api/' | ||
|
|
||
| const packageJson = 'package.json' | ||
| const yamlFile = 'serverless.yaml' |
Contributor
There was a problem hiding this comment.
(nit) I'm not 100% sure about yamlFile because it isn't descriptive as our other constants
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 9, 2020
# [1.2.0](v1.1.4...v1.2.0) (2020-06-09) ### Features * add setup script ([#17](#17)) ([094edd2](094edd2))
Contributor
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It implements a new script to set up the project, to avoid developers to replace by themselves the application name.
Any background context you want to provide?
This setup script includes running npm install command on the API and UI packages.
To run this new script, the developers need to run npm run setup --appName= --shortName= if shortName is not provided, the script will use appName instead.