Skip to content

Commit 1b267b0

Browse files
committed
Update concat to c307bee3933d88e6028274b0fa122a9b0c87b1d4
c307bee3933d88e6028274b0fa122a9b0c87b1d4 Merge pull request #366 from thrnio/fix_spec_vagrant 8484bc5072142c9f0cc5a90918e6e43efe4dedf0 Merge pull request #367 from thrnio/allow_integer_owner a6ebae9857e40e31179659401a64d81d57eac8d9 Allow integer UID/GID for $owner/$group 5efd30a0e193e1b95c3077c9610886df70735769 (MODULES-2572) Fix acceptance test vagrant URLs fd4f1e2d46a86f1659da420f4ce042882d38e021 Merge pull request #361 from jhoblitt/feature/selinux 60051ae55d1d398f0439ae91e9fdaf0d944789b4 add log/ to .gitignore ff1e65a901381349e3ed37591605e8baac24be21 (MODULES-2303) add selinux related params to concat type e250a262a5d8adf01640706d33ef6c8ffcd6a89c Merge pull request #364 from bmjen/fix-frag-backup ca58571ab2fd3619a9ae516987689d051b3814ff (MODULES-1700) Re-factored original fix, to not default to backing up fragments. 370e38aafe9aa155920a54179edc7384b6621570 Merge pull request #363 from jhoblitt/fix-broken-backup b6f1ac1d359fdf3e1fe95d411a430c71cb449eb1 (MODULES-1700) remove all reliance on resource defaults fede2461c1cf82267ba65b7f40b60b9d3e4d5ca1 Never backup fragments, no matter what $backup for concat resource is used 65a7cf29041265ee8bf35edef216cf160189cd9a Merge pull request #360 ac28069b1392938f7ced0f0ff34497bc2b75e716 Merge pull request #358 from buzzdeee/master d5c305c2bf03912987fe7eba0da31dccadb65805 Recent OpenBSD changed to ruby22 as default interpreter, that now is also used by Puppet, so adapt to that. b957bb9 Merge pull request #357 from mhaskel/revert-sol12 05426bb Revert "Add support for Solaris 12" fb022ee Merge pull request #355 from mhaskel/1.2.4-prep db914f1 1.2.4 prep 89fceb4 Merge pull request #354 from bmjen/merge-master d336ea0 Merge pull request #352 from mhaskel/pe_next_fixes c129edf Use AIO ruby if available c47e72c Merge pull request #351 from hunner/mergeback afe258a Merge remote-tracking branch 'puppetlabs/1.2.x' 848554e Merge pull request #350 from mhaskel/pe_next_fixes 408633f Missed a typo e936813 Merge pull request #348 from gwollman/bug/master/FreeBSD-ruby-interpreter 2f82480 Merge pull request #349 from mhaskel/pe_next_fixes a72be83 Use the correct vardir in the tests 839de04 (#2208) FreeBSD: call /usr/local/bin/ruby explicitly adb17a4 Merge pull request #344 from drewfisher314/ticket/2135-add-solaris-12 47359c3 Merge pull request #347 from mhaskel/aio_fix 967880f check for nil b36f071 Merge pull request #346 from mhaskel/aio_fix f654561 Default test vardir to the aio paths for *nix systems 8618076 Merge pull request #345 from mhaskel/aio_helper 7473415 Add helper to install puppet/pe/puppet-agent 588757d Merge pull request #343 from raphink/fix/is_pe_master 5bc2d58 Add support for Solaris 12 17b836b Compare $::is_pe as bool, not string 35958b3 Merge pull request #339 from hunner/add_helper 130a334 Merge pull request #340 from bmjen/╯°□°╯︵┻━┻ 52cb97c Update CHANGELOG with yanked 2.x releases 6ad7f74 Update spec tests for rspec-puppet 2.0 e71af81 (╯°□°)╯︵┻━┻ the 2.0.x rewrite 9dd00aa Add helper to install puppet/pe/puppet-agent b84f710 Merge pull request #335 from justinstoller/maint/master/set-puppet-version d39884e (maint) allow setting PUPPET_VERSION in acceptance 171a304 Merge pull request #334 from bmjen/fix-windows 0ea02e4 fixes special characters test to support windows file restrictions 375de4a Merge pull request #333 from puppetlabs/travisci_update 2059f81 Updated travisci file to do testing for Puppet 4 4c13cb0 Merge pull request #332 from bmjen/bug/safe-name-on-windows 4a78188 (MODULES-2094) Extend regexp to remove parenthesis on safe names 724dcaa Merge pull request #330 from duritong/fix_autorequire 09a380c (MODULES-2023) - autorequire the file we are generating 8d7d427 Merge pull request #328 from puppetlabs/2.0.x-to-master 5997e65 Merge pull request #326 from bmjen/refix-lint a5cce42 fixes bug introduced by a linting fix 6cecf8c Merge pull request #324 from bmjen/1.2.3_prep 75d1e96 Merge pull request #325 from bmjen/2.0.1_prep d6ee5a8 Release 2.0.1 prep 5267d35 1.2.3 Release prep 6751adb 1.2.3 Release prep b0c874b Merge pull request #323 from bmjen/update-readme d4376cb updates init.pp to pass linting abf40f0 update README with correct behavior for fragment parameter 1869563 Merge pull request #322 from DavidS/fixup-readme f1b7a50 Fixup the wording in README ddcf87f Merge pull request #321 from bmjen/empty-concats 6264171 Merge pull request #319 from bmjen/add-file-autorequire 64b9288 fix defaulted force behavior 773b858 Merge pull request #320 from DavidS/add-warn-warning b271bff (MODULES-2080) Call out changed behaviour of 'warn' parameter 78fdb4e adds file autorequire e9ee044 Merge pull request #318 from bmjen/frag-targeting db33829 fix fragment target handling 02c5f4b Merge pull request #317 from bmjen/tableflip 2292759 fixes dependency bug in creating the target file f4d4ca0 Add ability to unittest puppet 4 8c4e5fc Merge pull request #316 from bmjen/merge_2.0.x bb55d80 Merge pull request #314 from bmjen/2.0.0-prep ca73b72 fix linting 5ab5672 Merge pull request #313 from bmjen/2.0.0-prep 26033e6 2.0.0 release prep 9c5857f 1.2.2 release prep 2d5734c Merge pull request #312 from bmjen/1.2.2-prep b5f1764 update metadata.json 4ea84be Merge pull request #311 from bmjen/1.2.2-prep 8d04426 1.2.2 release prep d654dea Merge pull request #310 from puppetlabs/modulesync_updates 4be434d Lint fixes 84ee577 fix Gemfile 754c927 beaker gemfile fixes 16988df sync via modulesync 40cbb29 sync via modulesync ee3e184 Merge pull request #308 from cyberious/master 0587e37 Merge pull request #309 from justinstoller/maint/master/valid-json 32e417a (maint) fixup invalid JSON 1a2975a (maint) Only add newline if string does not end with newline f24437c Merge pull request #307 from bmjen/ensure-newline 118e802 readd ensure_newline param and tests for backwards compatibility b880a99 Merge pull request #306 from bmjen/re-refactor-2.0 6876399 re-refactor of concat to not depend on file_concat b2c4145 Merge pull request #305 from bmjen/fix-geppeto 1534050 fixes the metadata.json to be geppeto compliant bcf3af5 Merge pull request #304 from bmjen/update-dep-version cd21d8b update metadata.json with correct dependencies and setting exact version for file_concat dependency 253f497 Merge pull request #303 from bmjen/modules-1933 0459eba MODULES-1933: fixes backup passing in fragments without concat resource 562977a Merge pull request redhat-openstack#299 from psoloway/readme 6aebeea Merge pull request #302 from bmjen/cuz-strict-variables ef4aac8 fix for strict variables checking 2d64759 Update README per cd03959 16104d0 Merge pull request #300 from IceBear2k/master e562bcd Revert and fix regex 30cb251 Merge pull request redhat-openstack#298 from bmjen/fix-windows-acceptance 3809409 fixes acceptance tests on windows 583c528 Merge pull request redhat-openstack#296 from bmjen/fix-windows 6cfa62b fixes windows. e2b189e Merge pull request redhat-openstack#297 from bmjen/o_____p cd03959 re-add removed params for backwards compatibility ea5af52 Merge pull request redhat-openstack#295 from hunner/fix_metadata 2ccde9d Merge pull request redhat-openstack#294 from bmjen/geppetto-fix c96ae6a The jenkins geppetto plugin is still complaining 4e61c33 more geppetto lint fixes f23bd17 Merge pull request redhat-openstack#293 from bmjen/geppetto-fix 71c815b fix linting errors 5059019 Merge pull request redhat-openstack#291 from psoloway/readme 9970cc6 Merge pull request redhat-openstack#290 from bmjen/refactor-native ececd06 Merge pull request redhat-openstack#292 from bmjen/release-prep-1.2.1 8198296 Updates CHANGELOG and metadata for 1.2.1 release 51bd49f refactor concat to wrap electrical/file_concat d45e281 Updates README per 936dc29 15ecb98 Merge pull request redhat-openstack#288 from woneill/ticket/MODULES-1700-backup_files_for_static_compiler aa133e2 Override File default with backup value instead of assuming 'false' e34eac0 (MODULES-1700) Change the filebucketing behavior so static_compiler can handle them a0942af Merge pull request redhat-openstack#284 from buzzdeee/master 6f88096 Merge pull request redhat-openstack#287 from j-vizcaino/feature/setup-user-group-explicitly 936dc29 Merge pull request redhat-openstack#289 from puppetlabs/1.2.x c2d056b spec/setup: Fix indent e811550 setup: update tests to check for proper user/group ownership 0193fd2 setup: set user/group explicitly for dirs & script b20d8b9 Fix breakage on OpenBSD in similar fashion as it is done for Windows. Broken since the switch from the shell script to the ruby script. 710b3d5 Merge pull request redhat-openstack#268 from mhaskel/1.2.0-prep 7f97a0e 1.2.0 prep Change-Id: I01b7a6e43d8db5dd295ee610fc019175a6fa406c
1 parent 85af6c2 commit 1b267b0

29 files changed

Lines changed: 408 additions & 170 deletions

Puppetfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ mod 'common',
2727
:git => 'https://github.com/purpleidea/puppet-common.git'
2828

2929
mod 'concat',
30-
:commit => '52d0f1d6809c9f1d8453f9e3ca10d792e67acc89',
30+
:commit => 'c307bee3933d88e6028274b0fa122a9b0c87b1d4',
3131
:git => 'https://github.com/puppetlabs/puppetlabs-concat.git'
3232

3333
mod 'corosync',

concat/.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,3 +7,4 @@ spec/fixtures/
77
coverage/
88
.idea/
99
*.iml
10+
log/

concat/.travis.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
---
2+
sudo: false
23
language: ruby
34
bundler_args: --without system_tests
45
script: "bundle exec rake validate && bundle exec rake lint && bundle exec rake spec SPEC_OPTS='--format documentation'"
@@ -11,5 +12,7 @@ matrix:
1112
env: PUPPET_GEM_VERSION="~> 3.0"
1213
- rvm: 2.0.0
1314
env: PUPPET_GEM_VERSION="~> 3.0"
15+
- rvm: 2.1.6
16+
env: PUPPET_GEM_VERSION="~> 4.0" STRICT_VARIABLES="yes"
1417
notifications:
1518
email: false

concat/CHANGELOG.md

Lines changed: 62 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,65 @@
1+
##2015-07-21 - Supported Release 1.2.4
2+
###Summary
3+
4+
This release includes some ruby path and lint fixes.
5+
6+
####Bugfixes
7+
- Use correct ruby path with PE and AIO
8+
- Lint fixes
9+
- Use correct ruby path on FreeBSD
10+
- Test fixes
11+
12+
##2015-06-02 - Supported Release 2.0.1 [YANKED]
13+
###Summary
14+
15+
This is a bugfix release.
16+
17+
####Bugfixes
18+
- Fixes dependency graphing with concurrent modification of the same file.
19+
- Fixes handling fragment target.
20+
- Fixes the defaulted force behavior to handle empty concats correctly.
21+
22+
##2015-06-02 - Supported Release 1.2.3
23+
###Summary
24+
25+
This release includes a README fix to document correct behavior of fragment target parameter.
26+
27+
####Bugfixes
28+
- README Fix to correctly document how a fragment $target param should work.
29+
30+
##2015-05-12 - Supported Release 2.0.0 [YANKED]
31+
###Summary
32+
33+
This is a major release. Includes re-implementation of concat to use native Type and Providers, resulting in significantly improved performance and testability. Also includes a bugfix to alpha ordering of fragments.
34+
35+
####Features
36+
- Re-implementation of concat to use native Type and Providers.
37+
38+
####Bugfixes
39+
- Fixes a bug in alpha ordering of fragments.
40+
41+
##2015-05-12 - Supported Release 1.2.2
42+
###Summary
43+
44+
This release includes a bugfix.
45+
46+
####Bugfixes
47+
- Fixes a bug introduced by MODULES-1700, in handling default retrieval of fragment backup parameter.
48+
49+
##2015-04-14 - Supported Release 1.2.1
50+
###Summary
51+
52+
This release includes bugfixes, test improvements, and a rewritten README.
53+
54+
####Bugfixes
55+
56+
- Verifies existence of $is_pe before using it.
57+
- Adds validation for $order param to not allow restricted characters.
58+
- Sets the group id on Fragments for versions of Facter that contain the $gid fact.
59+
- Sets the script group to 0 if the script is owned by root.
60+
- Explicitly sets script and concat directories to the same owner and group.
61+
- Re-adds support for fragment backup, so that static compiler can work with filebucket (MODULES-1700).
62+
163
##2015-02-17 - Supported Release 1.2.0
264
###Summary
365

concat/Gemfile

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,38 +11,36 @@ def location_for(place, fake_version = nil)
1111
end
1212

1313
group :development, :unit_tests do
14-
gem 'rake', :require => false
1514
gem 'rspec-core', '3.1.7', :require => false
16-
gem 'rspec-puppet', '~> 1.0', :require => false
1715
gem 'puppetlabs_spec_helper', :require => false
18-
gem 'puppet-lint', :require => false
1916
gem 'simplecov', :require => false
2017
gem 'puppet_facts', :require => false
2118
gem 'json', :require => false
2219
end
2320

24-
beaker_version = ENV['BEAKER_VERSION']
25-
beaker_rspec_version = ENV['BEAKER_RSPEC_VERSION']
2621
group :system_tests do
27-
if beaker_version
22+
if beaker_version = ENV['BEAKER_VERSION']
2823
gem 'beaker', *location_for(beaker_version)
2924
end
30-
if beaker_rspec_version
25+
if beaker_rspec_version = ENV['BEAKER_RSPEC_VERSION']
3126
gem 'beaker-rspec', *location_for(beaker_rspec_version)
3227
else
3328
gem 'beaker-rspec', :require => false
3429
end
3530
gem 'serverspec', :require => false
31+
gem 'beaker-puppet_install_helper', :require => false
3632
end
3733

34+
35+
3836
if facterversion = ENV['FACTER_GEM_VERSION']
39-
gem 'facter', *location_for(facterversion)
37+
gem 'facter', facterversion, :require => false
4038
else
4139
gem 'facter', :require => false
4240
end
4341

4442
if puppetversion = ENV['PUPPET_GEM_VERSION']
45-
gem 'puppet', *location_for(puppetversion)
43+
gem 'puppet', puppetversion, :require => false
4644
else
4745
gem 'puppet', :require => false
4846
end

concat/README.md

Lines changed: 36 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,10 @@ All the parameters listed below are optional.
139139

140140
Specifies whether (and how) to back up the destination file before overwriting it. Your value gets passed on to Puppet's [native `file` resource](https://docs.puppetlabs.com/references/latest/type.html#file-attribute-backup) for execution. Valid options: 'true', 'false', or a string representing either a target filebucket or a filename extension beginning with ".". Default value: 'puppet'.
141141

142+
#####`backup_fragments`
143+
144+
Specifies whether to backup concat fragments using the backup setting of the target concat file. Valid options: 'true' and 'false'. Default value: 'false'.
145+
142146
#####`ensure`
143147

144148
Specifies whether the destination file should exist. Setting to 'absent' tells Puppet to delete the destination file if it exists, and negates the effect of any other parameters. Valid options: 'present' and 'absent'. Default value: 'present'.
@@ -195,6 +199,36 @@ If you set this parameter to 'true', Puppet adds the following message:
195199
# This file is managed by Puppet. DO NOT EDIT.
196200
~~~
197201

202+
#####`selinux_ignore_defaults`
203+
204+
See the `file` type's
205+
[`selinux_ignore_defaults`](https://docs.puppetlabs.com/references/latest/type.html#file-attribute-selinux_ignore_defaults)
206+
documentention.
207+
208+
#####`selrange`
209+
210+
See the `file` type's
211+
[`selrange`](https://docs.puppetlabs.com/references/latest/type.html#file-attribute-selrange)
212+
documentention.
213+
214+
#####`selrole`
215+
216+
See the `file` type's
217+
[`selrole`](https://docs.puppetlabs.com/references/latest/type.html#file-attribute-selrole)
218+
documentention.
219+
220+
#####`seltype`
221+
222+
See the `file` type's
223+
[`seltype`](https://docs.puppetlabs.com/references/latest/type.html#file-attribute-seltype)
224+
documentention.
225+
226+
#####`seluser`
227+
228+
See the `file` type's
229+
[`seluser`](https://docs.puppetlabs.com/references/latest/type.html#file-attribute-seluser)
230+
documentention.
231+
198232
####`concat::fragment`
199233

200234

@@ -218,7 +252,7 @@ Specifies a file to read into the content of the fragment. **Note**: You must su
218252

219253
#####`target`
220254

221-
*Required.* Specifies the destination file of the fragment. Valid options: a string containing an absolute path.
255+
*Required.* Specifies the destination file of the fragment. Valid options: a string containing the title of the parent `concat` resource.
222256

223257
###Deprecations
224258

@@ -280,4 +314,4 @@ For more information, see our [module contribution guide.](https://docs.puppetla
280314

281315
###Contributors
282316

283-
To see who's already involved, see the [list of contributors.](https://github.com/puppetlabs/puppetlabs-concat/graphs/contributors)
317+
To see who's already involved, see the [list of contributors.](https://github.com/puppetlabs/puppetlabs-concat/graphs/contributors)

concat/Rakefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
require 'puppetlabs_spec_helper/rake_tasks'
22
require 'puppet-lint/tasks/puppet-lint'
33

4-
PuppetLint.configuration.fail_on_warnings
4+
PuppetLint.configuration.fail_on_warnings = true
55
PuppetLint.configuration.send('relative')
66
PuppetLint.configuration.send('disable_80chars')
77
PuppetLint.configuration.send('disable_class_inherits_from_params_class')

concat/manifests/fragment.pp

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,16 @@
5757
if $backup {
5858
warning('The $backup parameter to concat::fragment is deprecated and has no effect')
5959
}
60+
61+
# Checks the target concat resources for whether fragments should be backed up or not
62+
# otherwise defaults to false.
63+
$enable_backup = concat_getparam(Concat[$target], 'backup_fragments')
64+
$target_backup = concat_getparam(Concat[$target], 'backup')
65+
$_backup = $enable_backup ? {
66+
true => $target_backup,
67+
default => false
68+
}
69+
6070
if $ensure == undef {
6171
$my_ensure = concat_getparam(Concat[$target], 'ensure')
6272
} else {
@@ -118,7 +128,7 @@
118128
mode => $fragmode,
119129
source => $source,
120130
content => $content,
121-
backup => false,
131+
backup => $_backup,
122132
replace => true,
123133
alias => "concat_fragment_${name}",
124134
notify => Exec["concat_${target}"]

0 commit comments

Comments
 (0)