Skip to content

Commit 611d964

Browse files
committed
Use UUID as the default token provider
Keystone changed it's default token provider to UUID for Juno. This patch changes the puppet-keystone default to match. One of the existing spec tests was incorrect, and had to be removed. The test was expecting signing certificate setup to be performed wen enable_ssl is True, but that setup is really only performed when configuring PKI format tokens. There is already a test that covers properly enabling SSL and PKI token format configuration, so this incorrect test can be removed. Change-Id: Id838bbb06602b9fe5331329c74872b62932ace1b Closes-bug: #1372991
1 parent a7c891b commit 611d964

2 files changed

Lines changed: 3 additions & 25 deletions

File tree

manifests/init.pp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
# [catalog_template_file] Path to the catalog used if catalog_type equals 'template'.
2828
# Defaults to '/etc/keystone/default_catalog.templates'
2929
# [token_provider] Format keystone uses for tokens. Optional.
30-
# Defaults to 'keystone.token.providers.pki.Provider'
30+
# Defaults to 'keystone.token.providers.uuid.Provider'
3131
# Supports PKI and UUID.
3232
# [token_driver] Driver to use for managing tokens.
3333
# Optional. Defaults to 'keystone.token.backends.sql.Token'
@@ -232,7 +232,7 @@
232232
$catalog_driver = false,
233233
$catalog_template_file = '/etc/keystone/default_catalog.templates',
234234
$token_format = false,
235-
$token_provider = 'keystone.token.providers.pki.Provider',
235+
$token_provider = 'keystone.token.providers.uuid.Provider',
236236
$token_driver = 'keystone.token.backends.sql.Token',
237237
$token_expiration = 3600,
238238
$public_endpoint = false,

spec/classes/keystone_spec.rb

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
'debug' => false,
2020
'catalog_type' => 'sql',
2121
'catalog_driver' => false,
22-
'token_provider' => 'keystone.token.providers.pki.Provider',
22+
'token_provider' => 'keystone.token.providers.uuid.Provider',
2323
'token_driver' => 'keystone.token.backends.sql.Token',
2424
'cache_dir' => '/var/cache/keystone',
2525
'enable_ssl' => false,
@@ -475,28 +475,6 @@
475475
it { should contain_keystone_config('DEFAULT/admin_bind_host').with_value('10.0.0.2') }
476476
end
477477

478-
describe 'when configuring as SSL' do
479-
let :params do
480-
{
481-
'admin_token' => 'service_token',
482-
'enable_ssl' => true
483-
}
484-
end
485-
it { should contain_exec('keystone-manage pki_setup').with(
486-
:creates => '/etc/keystone/ssl/private/signing_key.pem'
487-
) }
488-
it { should contain_file('/var/cache/keystone').with_ensure('directory') }
489-
describe 'when overriding the cache dir' do
490-
let :params do
491-
{
492-
'admin_token' => 'service_token',
493-
'enable_ssl' => true,
494-
'cache_dir' => '/var/lib/cache/keystone'
495-
}
496-
end
497-
it { should contain_file('/var/lib/cache/keystone') }
498-
end
499-
end
500478
describe 'when enabling SSL' do
501479
let :params do
502480
{

0 commit comments

Comments
 (0)