Skip to content

Commit 966e0b5

Browse files
author
Bogdan Dobrelya
committed
Add retries for non transient file transfer errors
W/o this patch, Rabbitmq::Install::Rabbitmqadmin/Staging::File[rabbitmqadmin] /Exec[/var/lib/rabbitmq/rabbitmqadmin] sometimes could fail the curl command due to transient or connectivity errors. The solution is: - For transient errors: * use timeout param for staging::file * use --retries , --retry-delay flag for curl command passed to staging::file - For connectivity errors: * improve staging module to retry its commands as well, see https://github.com/nanliu/puppet-staging/pull/52 Closes-bug: #MODULES-1650 Signed-off-by: Bogdan Dobrelya <bdobrelia@mirantis.com>
1 parent cf30101 commit 966e0b5

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

manifests/install/rabbitmqadmin.pp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@
1515
staging::file { 'rabbitmqadmin':
1616
target => '/var/lib/rabbitmq/rabbitmqadmin',
1717
source => "${protocol}://${default_user}:${default_pass}@localhost:${management_port}/cli/rabbitmqadmin",
18-
curl_option => '-k --noproxy localhost',
18+
curl_option => '-k --noproxy localhost --retry 30 --retry-delay 6',
19+
timeout => '180',
1920
wget_option => '--no-proxy',
2021
require => [
2122
Class['rabbitmq::service'],

0 commit comments

Comments
 (0)