Ensure error log is present before trying to manage ownership

Colleen Murphy · Colleen Murphy · commit ec6b97ea5db1 · 2014-10-07T14:28:00.000-07:00
If mysql generates an error log in between puppet runs, the log's
ownership and group might not match the ownership and group set by the
file resource. This means sequential puppet runs will appear not to be
idempotent. This patch makes sure the file is there from the start so
that it doesn't have to change its ownership later.
diff --git a/manifests/server/service.pp b/manifests/server/service.pp
@@ -10,8 +10,9 @@
   }
 
   file { $mysql::params::log_error:
-    owner => 'mysql',
-    group => 'mysql',
+    ensure => present,
+    owner  => 'mysql',
+    group  => 'mysql',
   }
 
   service { 'mysqld':

Original file line number	Diff line number	Diff line change
`@@ -10,8 +10,9 @@`
`10`	`10`	`}`
`11`	`11`
`12`	`12`	`file { $mysql::params::log_error:`
`13`		`- owner => 'mysql',`
`14`		`- group => 'mysql',`
	`13`	`+ ensure => present,`
	`14`	`+ owner => 'mysql',`
	`15`	`+ group => 'mysql',`
`15`	`16`	`}`
`16`	`17`
`17`	`18`	`service { 'mysqld':`