Fix onDateChange on iOS#123
Merged
feyy merged 2 commits intoxgfe:masterfrom May 16, 2017
Merged
Conversation
|
I've pulled this change into one of my projects and it has resolved all date change issues I was experiencing. Thank you so much. Hoping this gets pulled into the project soon. |
Contributor
|
Wonderful! It dose work. But why set 500ms timeout? Whether it can be sonner? |
Author
|
It could probably work with a shorter timeout but I don't know what is the limit that will work in all situations and devices. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an issue with DatepickerIOS regarding onDateChange facebook/react-native#8169 . This is not fixed yet but there is a workaround suggested that I applied on
react-native-datepicker