Added an option to disable the Date Text and update the README#127
Merged
feyy merged 2 commits intoxgfe:masterfrom Jun 12, 2017
Merged
Added an option to disable the Date Text and update the README#127feyy merged 2 commits intoxgfe:masterfrom
feyy merged 2 commits intoxgfe:masterfrom
Conversation
Contributor
|
Thanks very much! But you can hide the text with style. Can your update the readme with another issue and using markdown only? Or I'll fix by myself. |
Contributor
Author
Contributor
Author
|
@feyy Here what I get with: customStyles={{
dateInput: {
borderStyle: null,
height: 0,
width: 0,
}
}}(I still get the little dot at the left) But with this PR, as the textInput won't render anymore, I will be able to delete this little dot. Is this possible to merge it ? |
Contributor
Author
|
Hi @feyy! I've upgraded to react-native v0.45 and it seems that you can't hide the text with style anymore. Can you confirm that? with this style: dateInput: {
borderWidth: 0,
borderStyle: null,
height: 0,
width: 0,
}, |
Contributor
Author
|
@feyy I've tested this PR on RN v0.45 and it works well. Could you merge this please ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Added an option to disable the TextInput (hideText), added it to the README and fixed the README array