Skip to content

Commit c1c201b

Browse files
authored
Merge 30a1506 into 1b4620e
2 parents 1b4620e + 30a1506 commit c1c201b

2 files changed

Lines changed: 10 additions & 11 deletions

File tree

ydb/core/blobstorage/vdisk/hullop/blobstorage_hullcommit.h

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -139,14 +139,10 @@ namespace NKikimr {
139139

140140
// notify delayed deleter when log record is actually written; we MUST ensure that updates are coming in
141141
// order of increasing LSN's; this is achieved automatically as all actors reside on the same mailbox
142-
if (WId) {
143-
LevelIndex->DelayedCompactionDeleterInfo->Update(LsnSeg.Last, std::move(Metadata.RemovedHugeBlobs),
144-
CommitRecord.DeleteToDecommitted ? CommitRecord.DeleteChunks : TVector<TChunkIdx>(),
145-
PDiskSignatureForHullDbKey<TKey>(), WId, ctx, Ctx->HugeKeeperId, Ctx->SkeletonId, Ctx->PDiskCtx,
146-
Ctx->HullCtx->VCtx);
147-
} else {
148-
Y_ABORT_UNLESS(Metadata.RemovedHugeBlobs.Empty());
149-
}
142+
LevelIndex->DelayedCompactionDeleterInfo->Update(LsnSeg.Last, std::move(Metadata.RemovedHugeBlobs),
143+
CommitRecord.DeleteToDecommitted ? CommitRecord.DeleteChunks : TVector<TChunkIdx>(),
144+
PDiskSignatureForHullDbKey<TKey>(), WId, ctx, Ctx->HugeKeeperId, Ctx->SkeletonId, Ctx->PDiskCtx,
145+
Ctx->HullCtx->VCtx);
150146

151147
NPDisk::TEvLogResult* msg = ev->Get();
152148

ydb/core/blobstorage/vdisk/hullop/hullcompdelete/blobstorage_hullcompdelete.h

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,6 @@ namespace NKikimr {
9494
ui64 wId, const TActorContext& ctx, const TActorId& hugeKeeperId, const TActorId& skeletonId,
9595
const TPDiskCtxPtr& pdiskCtx, const TVDiskContextPtr& vctx) {
9696
Y_ABORT_UNLESS(recordLsn > LastDeletionLsn);
97-
Y_ABORT_UNLESS(!removedHugeBlobs.Empty());
9897
LastDeletionLsn = recordLsn;
9998
LOG_DEBUG_S(ctx, NKikimrServices::BS_HULLCOMP, vctx->VDiskLogPrefix
10099
<< "TDelayedCompactionDeleter: Update recordLsn# " << recordLsn << " removedHugeBlobs.size# "
@@ -223,8 +222,12 @@ namespace NKikimr {
223222
TReleaseQueueItem& item = ReleaseQueue.front();
224223
if (CurrentSnapshots.empty() || (item.RecordLsn <= CurrentSnapshots.begin()->first)) {
225224
// matching record -- commit it to huge hull keeper and throw out of the queue
226-
ctx.Send(hugeKeeperId, new TEvHullFreeHugeSlots(std::move(item.RemovedHugeBlobs),
227-
item.RecordLsn, item.Signature, item.WId));
225+
if (item.WId) {
226+
ctx.Send(hugeKeeperId, new TEvHullFreeHugeSlots(std::move(item.RemovedHugeBlobs),
227+
item.RecordLsn, item.Signature, item.WId));
228+
} else {
229+
Y_ABORT_UNLESS(item.RemovedHugeBlobs.Empty());
230+
}
228231
if (item.ChunksToForget) {
229232
LOG_DEBUG(ctx, NKikimrServices::BS_VDISK_CHUNKS, VDISKP(vctx->VDiskLogPrefix,
230233
"FORGET: PDiskId# %s ChunksToForget# %s", pdiskCtx->PDiskIdString.data(),

0 commit comments

Comments
 (0)