Conditionally compile the code that uses AWS to pass windows build#8966
Conversation
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
|
||
| IF (OS_WINDOWS) | ||
| CFLAGS( | ||
| -DKIKIMR_DISABLE_S3_OPS |
There was a problem hiding this comment.
I thought that KIKIMR_DISABLE_S3_OPS flag would be inherited from ydb/apps/ydbd/ya.make. However, this was not the case in my tests, so I included it here.
|
⚪ ⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
This commit (#8823) breaks:
This PR fixes the first problem (broken windows build). The second problem cannot be fixed in GitHub and must be fixed in the next import to arcadia/contrib PR. (The fix is ready.)