`OpenStreamMalformedContentLength.OutOfRange` is flaky

[Tachi107]

Sometimes the open_stream call fails, and handle.error is "Failed to write connection (5)".

This is quite easy to reproduce with while build/test/main --gtest_filter=OpenStreamMalformedContentLength.OutOfRange; do : ; done

[yhirose]

@Tachi107 thanks for the report, but I couldn't reproduce it. I run the test on my M1 MacBook Pro.

[Tachi107]

I'm using Debian testing, could you maybe try with a Linux VM?

I re-tested with the test/Makefile and the issue persists:

$ git clone https://github.com/yhirose/cpp-httplib.git
$ cd cpp-httplib/
$ cd test/
$ make test CXX=c++
$ while ./test --gtest_filter=OpenStreamMalformedContentLength.OutOfRange; do : ; done | grep -E 'PASSED|FAILED'
[  PASSED  ] 1 test.
[  PASSED  ] 1 test.
[  PASSED  ] 1 test.
[  PASSED  ] 1 test.
[  PASSED  ] 1 test.
[  PASSED  ] 1 test.
[  PASSED  ] 1 test.
[  PASSED  ] 1 test.
[  FAILED  ] OpenStreamMalformedContentLength.OutOfRange (2 ms)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] OpenStreamMalformedContentLength.OutOfRange
 1 FAILED TEST

[yhirose]

[yhirose]

@Tachi107 could you test with httplib.h in #2428 for me, since I am not able to reproduce this issue on my MacBook and Ubuntu. This change is suggested by Opus 4.6. Thanks!

[Tachi107]

In the image I see that you’ve run the loop multiple times. The while should terminate only if the test fails: did you stop it, or it stopped on its own? What if you don’t filter the output with grep?

[yhirose]

I confirmed it's fixed with #2428 on Ubuntu on WSL2 on Windows 11.

~/Projects/cpp-httplib/test$ while setarch $(uname -m) -R ./test --gtest_filter=OpenStreamMalformedContentLength.OutOfRange; do : ; done | grep -E 'PASSED|FAILED'
[  PASSED  ] 1 test.
[  PASSED  ] 1 test.
[  PASSED  ] 1 test.
[  PASSED  ] 1 test.
[  PASSED  ] 1 test.
[  PASSED  ] 1 test.
[  PASSED  ] 1 test.
[  PASSED  ] 1 test.
[  PASSED  ] 1 test.
[  PASSED  ] 1 test.
...
...
...

[Tachi107]

I can confirm it's fixed too. Thanks!