Skip to content

Commit acc87bf

Browse files
loredanacirsteaHuangYi
authored andcommitted
Quick fix for eth_feeHistory when reward is nil (evmos#975)
* Quick fix for eth_feeHistory when reward is nil `RPC method eth_feeHistory crashed: runtime error: invalid memory address or nil pointer dereference` from https://github.com/tharsis/ethermint/blob/caa1c5a6c6b7ed8ba4aaf6e0b0848f6be5ba6668/rpc/ethereum/backend/feebackend.go#L29 * Update CHANGELOG.md
1 parent a50901f commit acc87bf

2 files changed

Lines changed: 7 additions & 0 deletions

File tree

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,10 @@ Ref: https://keepachangelog.com/en/1.0.0/
3737

3838
## Unreleased
3939

40+
### Bug Fixes
41+
42+
* (rpc) [#970] (https://github.com/tharsis/ethermint/pull/970) Fix unexpected nil reward values on `eth_feeHistory` response
43+
4044
### API Breaking
4145

4246
* (ante) [\#866](https://github.com/tharsis/ethermint/pull/866) `NewAnteHandler` constructor now receives a `HandlerOptions` field.

rpc/ethereum/backend/feebackend.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,9 @@ func (e *EVMBackend) processBlock(
8787
}
8888
tx := ethMsg.AsTransaction()
8989
reward := tx.EffectiveGasTipValue(blockBaseFee)
90+
if reward == nil {
91+
reward = big.NewInt(0)
92+
}
9093
sorter[i] = txGasAndReward{gasUsed: txGasUsed, reward: reward}
9194
break
9295
}

0 commit comments

Comments
 (0)