Conversation
* chore: migrate rand dependencies to 0.10 * chore: verify rand migration * docs: add rand migration changelog entry * chore: keep no-std crypto deps off getrandom 0.2 * chore: update fuzz lockfile for no-std deps
The rand 0.10 migration removed transitive feature unification that had been enabling once_cell/std for miden-crypto. The scheduled fuzz workflow caught the resulting critical-section undefined symbols because cargo-fuzz performs the final sanitizer link, but the PR fuzz check only ran cargo check, which type-checks metadata and does not link executables. Enable once_cell/std from miden-crypto's std feature directly, and make check-fuzz build every cargo-fuzz target with nightly. The build workflow now installs nightly and the pinned cargo-fuzz version so future link-only fuzz regressions fail during PR checks instead of waiting for the scheduled fuzz run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a tracking PR for v0.26.0 release.