Skip to content

fix: network transaction executor + network monitor#1826

Merged
mmagician merged 1 commit intommagician-claude/update-base-to-betafrom
igamigo-network-monitor
Mar 24, 2026
Merged

fix: network transaction executor + network monitor#1826
mmagician merged 1 commit intommagician-claude/update-base-to-betafrom
igamigo-network-monitor

Conversation

@igamigo
Copy link
Copy Markdown
Collaborator

@igamigo igamigo commented Mar 23, 2026 •
edited
Loading

This PR contains 2 fixes:

  • on the NTX builder, creates the executor with a valid core trace fragment size
  • updates the monitor code for the new Word stack orientation changes in the new VM revision

Found while running client integration tests:

thread 'tokio-rt-worker' (15182569) panicked at .cargo/git/checkouts/miden-node-98c06b5d084e5405/b59b408/crates/ntx-builder/src/actor/execute.rs:143:18:
max_cycles should be within valid range: CoreTraceFragmentSizeTooSmall
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@igamigo igamigo added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Mar 23, 2026
@igamigo igamigo marked this pull request as ready for review March 23, 2026 21:32
@igamigo igamigo mentioned this pull request Mar 23, 2026
Open
Mirko-von-Leipzig
Mirko-von-Leipzig approved these changes Mar 24, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Mirko-von-Leipzig Mirko-von-Leipzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

mmagician
mmagician approved these changes Mar 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@mmagician mmagician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@mmagician mmagician merged commit 0cc4066 into mmagician-claude/update-base-to-beta Mar 24, 2026
15 of 16 checks passed
@mmagician mmagician deleted the igamigo-network-monitor branch March 24, 2026 11:06
@igamigo igamigo mentioned this pull request Mar 24, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmagician mmagician mmagician approved these changes

@Mirko-von-Leipzig Mirko-von-Leipzig Mirko-von-Leipzig approved these changes

Assignees

No one assigned

Labels

no changelog This PR does not require an entry in the `CHANGELOG.md` file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@igamigo @mmagician @Mirko-von-Leipzig