feat(block-producer): fix dangling review comments#522
Merged
Mirko-von-Leipzig merged 4 commits intonext-block-producerfrom Oct 24, 2024
Merged
feat(block-producer): fix dangling review comments#522Mirko-von-Leipzig merged 4 commits intonext-block-producerfrom
Mirko-von-Leipzig merged 4 commits intonext-block-producerfrom
Conversation
Mirko-von-Leipzig
added
the
no changelog
bobbinth
reviewed
Oct 24, 2024
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I left just 2 nits inline.
Question: currently BatchProducer and BlockProducer structs are unused, right?
Comment on lines
+233
to
+235
| /// Used to simulate batch proving by sleeping for | ||
| /// a random duration selected from this range. | ||
| pub simulated_proof_time: Range<Duration>, |
Contributor
There was a problem hiding this comment.
nit: we usually wrap comments around 100 chars.
Comment on lines
+158
to
+160
| /// Used to simulate block proving by sleeping for | ||
| /// a random duration selected from this range. | ||
| pub simulated_proof_time: Range<Duration>, |
Collaborator
Author
Correct; one of the next PRs would replace the current production producers with these ones. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Specifically, addresses this, this and this comment.
Proving times are distributed normally from within a configurable range.
Failure rates are also similarly configurable, which completes one task from #519.