fix(mempool): allow internal batch dependencies#549
Merged
Mirko-von-Leipzig merged 13 commits intonext-block-producerfrom Nov 29, 2024
Merged
fix(mempool): allow internal batch dependencies#549Mirko-von-Leipzig merged 13 commits intonext-block-producerfrom
Mirko-von-Leipzig merged 13 commits intonext-block-producerfrom
Conversation
Clippy issue rust-lang/rust-clippy#12281 was fixed in v1.81. We now have MSRV of 1.82 allowing us to remove our workaround. More specifically, #[async_trait] was triggering this lint, and as of 1.81 no longer does.
* refactor: improve `ApplyBlockErrors` variants * docs: update `CHANGELOG.md` * refactor: address review comments
* Update state.rs * docs: Update expect() * chore: Lints
Improve block-producer top-level errors.
igamigo
reviewed
Nov 19, 2024
Collaborator
igamigo
left a comment
igamigo
left a comment
There was a problem hiding this comment.
Overall LGTM, but not too familiar with the context of the graph which was causing the issue in the first place so leaving a few comments while I check out the rest of the codebase
bobbinth
approved these changes
Nov 24, 2024
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I left a couple of small comments inline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash when a batch contained both a parent and child transaction.
In addition, this PR improves the error presentation when the node crashes.
Background: client integration tests were stalling when run against the new mempool based block-producer. This PR fixes the bug that causes this.
The stall occurred because the block-producer component exited, but the node continued on as it only crashes if a component errors. This PR rectifies this behaviour; we now crash the node if any component ends. In addition, this PR improves the errors by identifying the failing component.
This PR also merges in
next. This was required to properly compare and debug the client integration tests. It might be best to review the last few commits instead.