feat(block-producer): merge in next#561
Merged
Mirko-von-Leipzig merged 11 commits intonext-block-producerfrom Dec 4, 2024
Merged
feat(block-producer): merge in next#561Mirko-von-Leipzig merged 11 commits intonext-block-producerfrom
Mirko-von-Leipzig merged 11 commits intonext-block-producerfrom
Conversation
Clippy issue rust-lang/rust-clippy#12281 was fixed in v1.81. We now have MSRV of 1.82 allowing us to remove our workaround. More specifically, #[async_trait] was triggering this lint, and as of 1.81 no longer does.
* refactor: improve `ApplyBlockErrors` variants * docs: update `CHANGELOG.md` * refactor: address review comments
* Update state.rs * docs: Update expect() * chore: Lints
Previously only http was supported.
* refactor: remove unused dependencies, migrate code to the latest `next` of `miden-base` * chore: update `miden-base` * refactor: migrate to `assert_matches!` macro * chore: switch to the `next` branch of `miden-base` * refactor: add missed `assert_matches!`
Mirko-von-Leipzig
force-pushed
the
mirko/merge-next
branch
from
290584d to
ad34d20
Compare
Mirko-von-Leipzig
force-pushed
the
mirko/merge-next
branch
from
ad34d20 to
8060368
Compare
Mirko-von-Leipzig
added
the
no changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge
nextintonext-block-producerso that we can perform the reverse merge afterwards.Doing this as a PR so we can sanity check the diff. Once CI passes I'll force push this into
next-block-producer.