Skip to content

fix: avoid collisions in random numbers #2492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhilippGackstatter merged 1 commit into from
Feb 23, 2026
Merged

fix: avoid collisions in random numbers #2492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/miden-protocol/src/errors/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,7 +807,7 @@ pub enum ProvenTransactionError {
)]
ExistingPublicStateAccountRequiresDeltaDetails(AccountId),
#[error("failed to construct output notes for proven transaction")]
OutputNotesError(TransactionOutputError),
OutputNotesError(#[source] TransactionOutputError),
#[error(
"account update of size {update_size} for account {account_id} exceeds maximum update size of {ACCOUNT_UPDATE_MAX_SIZE}"
)]
Expand Down
18 changes: 10 additions & 8 deletions crates/miden-testing/src/kernel_tests/batch/proposed_batch.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,14 +529,16 @@ fn input_and_output_notes_commitment() -> anyhow::Result<()> {
// Randomize the note IDs and nullifiers on each test run to make sure the sorting property
// is tested with various inputs.
let mut rng = rand::rng();

let note0 = mock_output_note(rng.random());
let note1 = mock_note(rng.random());
let note2 = mock_output_note(rng.random());
let note3 = mock_output_note(rng.random());
let note4 = mock_note(rng.random());
let note5 = mock_note(rng.random());
let note6 = mock_note(rng.random());
// Generate a single random number and derive other unique numbers from it to avoid collisions.
let note_num = rng.random();

let note0 = mock_output_note(note_num);
let note1 = mock_note(note_num.wrapping_add(1));
let note2 = mock_output_note(note_num.wrapping_add(2));
let note3 = mock_output_note(note_num.wrapping_add(3));
let note4 = mock_note(note_num.wrapping_add(4));
let note5 = mock_note(note_num.wrapping_add(5));
let note6 = mock_note(note_num.wrapping_add(6));

let tx1 =
MockProvenTxBuilder::with_account(account1.id(), Word::empty(), account1.to_commitment())
Expand Down