fix(idxdb-store): replace expect() with StoreError in get_transactions when tx_script is missing#24
Open
WiktorStarczewski wants to merge 1 commit intonextfrom
Open
Conversation
…s when tx_script is missing Migrated from 0xMiden/miden-client#2050 (author: bigeez) as part of the web-sdk split. Original PR: 0xMiden/miden-client#2050
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated from miden-client#2050 (author: @bigeez) as part of the web-sdk split (web/WASM components moved out of miden-client into this dedicated repo — see miden-client #1992 / #2135).
Summary (per the original PR)
Replaces a
.expect()panic with properStoreErrorpropagation inget_transactions()when a transaction hasscript_rootset buttx_scriptis missing from the database.The
script_rootandtx_scriptwrites are non-atomic (two separate JS calls —idxdb_insert_transaction_script()thenidxdb_upsert_transaction_record()); if one succeeds while the other fails (e.g. a JS-side error swallowed vialogWebStoreError), the read path used to panic. Now it propagates aStoreError::DatabaseErrorthrough the existingResult.The CHANGELOG and sqlite-store changes from the original PR stay on miden-client#2050.