feat(agent): add ToolResultReviewer trait for critiquing tool results#1192
Draft
Phoenix500526 wants to merge 3 commits into0xPlaygrounds:mainfrom
Draft
feat(agent): add ToolResultReviewer trait for critiquing tool results#1192Phoenix500526 wants to merge 3 commits into0xPlaygrounds:mainfrom
Phoenix500526 wants to merge 3 commits into0xPlaygrounds:mainfrom
Conversation
- Add `ToolResultReviewer` trait with `critique()` method returning the final output - Extend `PromptRequest` with generic parameter `R` and `with_reviewer()` builder - Only critique successful tool executions; skip on failure - Reviewer controls the final output format (useful for JSON tool results) - Add example demonstrating usage with a small model reviewer Signed-off-by: Jiawei Zhao <Phoenix500526@163.com>
Signed-off-by: Jiawei Zhao <Phoenix500526@163.com>
Phoenix500526
force-pushed
the
feat/tool-critique
branch
from
d92d0b1 to
064b43b
Compare
- Add reviewer generic parameter and field to StreamingPromptRequest - Add with_reviewer() builder method - Invoke critique() after successful tool execution in streaming flow Signed-off-by: Jiawei Zhao <Phoenix500526@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ToolResultReviewertrait withcritique()method returning the final outputPromptRequestwith generic parameterRandwith_reviewer()builderCloses: #1191