fix(embeddings): respect token limits in EmbeddingsBuilder batching#1221
Open
godnight10061 wants to merge 1 commit into0xPlaygrounds:mainfrom
Open
fix(embeddings): respect token limits in EmbeddingsBuilder batching#1221godnight10061 wants to merge 1 commit into0xPlaygrounds:mainfrom
godnight10061 wants to merge 1 commit into0xPlaygrounds:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #462
Summary
EmbeddingsBuilder::build()previously batched only byM::MAX_DOCUMENTS. For providers like OpenAI embeddings, requests can also fail when the combined input exceeds the provider’s per-request token budget.Changes
EmbeddingModel::max_tokens_per_request()(defaultNone) so providers can expose a per-request token budget.M::MAX_DOCUMENTSandmax_tokens_per_request()(usestext.len()as a conservative proxy for tokens to avoid adding a tokenizer dependency).Some(300_000)(based on the provider error in the issue).Test
cargo test -p rig-core --lib