refactor!: add blobs support to SDK api#60
Merged
marcello33 merged 4 commits into0xPolygon:api/v0.7.5-upgradefrom Apr 29, 2025
Merged
refactor!: add blobs support to SDK api#60marcello33 merged 4 commits into0xPolygon:api/v0.7.5-upgradefrom
marcello33 merged 4 commits into0xPolygon:api/v0.7.5-upgradefrom
Conversation
|
Looks good. Once it is merged, please add a tag so we can import it in the main code. |
sergio-mena
approved these changes
Apr 29, 2025
sergio-mena
left a comment
There was a problem hiding this comment.
LGTM.
I'm not sure the references to EIP-4844 should stay. This design is independent from any EIP.
Also, at high level, the blob is associated with the block, not with individual transactions. Although the logic using it may do so.
marcello33
approved these changes
Apr 29, 2025
Collaborator
marcello33
left a comment
There was a problem hiding this comment.
LGTM, leaving last word to @avalkov
avalkov
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Do not merge–change base against api/0.7.5` branchIn order to add Blobs support to Cosmos SDK
v0.1.16-beta-polygon, we first need to upgrade its dependency toapi/v0.7.5. This PR updates the tendermint proto defintion to support Blobs.Changes
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Nodes audience
In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)
Checklist
Cross repository changes
Testing
Manual tests
Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it