Skip to content

refactor!: add blobs support to SDK api#60

Merged
marcello33 merged 4 commits into0xPolygon:api/v0.7.5-upgradefrom
informalsystems:polygon/blobs-api-v075
Apr 29, 2025
Merged

refactor!: add blobs support to SDK api#60
marcello33 merged 4 commits into0xPolygon:api/v0.7.5-upgradefrom
informalsystems:polygon/blobs-api-v075

Conversation

@sainoe
Copy link

@sainoe sainoe commented Apr 25, 2025

Description

Do not merge–change base against api/0.7.5` branch

In order to add Blobs support to Cosmos SDK v0.1.16-beta-polygon, we first need to upgrade its dependency to api/v0.7.5. This PR updates the tendermint proto defintion to support Blobs.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Cross repository changes

  • This PR requires changes to bor
    • In case link the PR here:
  • This PR requires changes to heimdall-v2
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on amoy/mumbai
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@sainoe sainoe changed the base branch from main to api/v0.7.5-upgrade April 28, 2025 15:15
@sainoe sainoe marked this pull request as ready for review April 28, 2025 15:16
@greg-szabo
Copy link

greg-szabo commented Apr 28, 2025

Looks good. Once it is merged, please add a tag so we can import it in the main code.

Copy link

@sergio-mena sergio-mena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I'm not sure the references to EIP-4844 should stay. This design is independent from any EIP.
Also, at high level, the blob is associated with the block, not with individual transactions. Although the logic using it may do so.

Copy link
Collaborator

@marcello33 marcello33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, leaving last word to @avalkov

@marcello33 marcello33 merged commit 7177eba into 0xPolygon:api/v0.7.5-upgrade Apr 29, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants