Skip to content

Fix: Block content pulled through external connections get converted to classic#534

Merged
jeffpaul merged 7 commits intodevelopfrom
fix/516
Mar 12, 2020
Merged

Fix: Block content pulled through external connections get converted to classic#534
jeffpaul merged 7 commits intodevelopfrom
fix/516

Conversation

@dinhtungdu
Copy link
Copy Markdown
Contributor

Description of the Change

  • Add: A new helper function to detect if the current site is using Gutenberg or not.
  • Fix: get correct content when pulling block-based posts through external connections.

See: #516 (comment)

Alternate Designs

n/a

Benefits

Better support for block editor.

Possible Drawbacks

n/a

Verification Process

  1. Activate block editor/Gutenber on both sites.
  2. Go to Distributor > Pull Content.
  3. Choose the target external connection.
  4. Pull a post that has blocks.
  5. See the pulled post has identical content with block display correctly.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Close #516

Changelog Entry

@adamsilverstein
Copy link
Copy Markdown

@dinhtungdu you might want to consider supporting VIP's ramp here if they are still using it: https://github.com/Automattic/gutenberg-ramp

@jeffpaul jeffpaul added the type:bug Something isn't working. label Mar 3, 2020
@jeffpaul jeffpaul added this to the 2.0.0 milestone Mar 3, 2020
@jeffpaul jeffpaul requested a review from dkotter March 3, 2020 14:43
@dinhtungdu
Copy link
Copy Markdown
Contributor Author

@adamsilverstein Thanks for the heads up! I added support for Gutenberg Ramp. If you have time, please take a look : )

dkotter
dkotter previously approved these changes Mar 9, 2020
@dkotter
Copy link
Copy Markdown
Collaborator

dkotter commented Mar 9, 2020

@dinhtungdu Tested this and seems to work great! There are a few linting errors, so if you can get those cleaned up, I think this will be good to merge.

Edit: also seems some WPA tests are failing that we should fix up.

@jeffpaul jeffpaul merged commit 1d049d9 into develop Mar 12, 2020
@jeffpaul jeffpaul deleted the fix/516 branch June 30, 2020 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Something isn't working.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

all content arriving as single classic block, can't publish

4 participants