Use post abstraction to override content.#988
Merged
Conversation
peterwilsoncc
force-pushed
the
do/use-post-abstraction
branch
from
90d9f6a to
a82444a
Compare
peterwilsoncc
force-pushed
the
do/use-post-abstraction
branch
from
27b29f0 to
12677ad
Compare
peterwilsoncc
commented
Dec 20, 2022
dkotter
approved these changes
Jan 5, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Removes duplicated code in the various connections to make use of the
DistributorPostclass.While this removes the duplication of code, it adds a lot of test so there is a net gain of about 1500 lines of code.
Closes #989
How to test the Change
Changelog Entry
Credits
Props @peterwilsoncc
Checklist: