Improved error handling, partially closes #46#47
Merged
17cupsofcoffee merged 1 commit into17cupsofcoffee:masterfrom Dec 20, 2018
VictorKoenders:improved_error
Merged
Improved error handling, partially closes #46#4717cupsofcoffee merged 1 commit into17cupsofcoffee:masterfrom VictorKoenders:improved_error
17cupsofcoffee merged 1 commit into17cupsofcoffee:masterfrom
VictorKoenders:improved_error
Conversation
Contributor
Author
|
Failure is my preferred crate for handling errors, for what it's worth. |
Owner
|
I seem to have a knack for picking up issues about half an hour before you submit a PR 😅 Sorry about that! I added a couple of these I quite like Failure too, but it seems like its future is in flux a bit since the RFC for fixing the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw #46 was closed 5 min ago but I was already working on it, so if you still want it, here it is!