Open
Conversation
alexsobledotgov
commented
Nov 14, 2024
| parent: engineering_approach | ||
| key: Releasing software | ||
| order: 10 | ||
| order: 9 |
Contributor
Author
There was a problem hiding this comment.
three different pages currently have order: 10, which isn't helpful for setting page order!
alexsobledotgov
commented
Nov 14, 2024
| parent: engineering_approach | ||
| key: Assessment guide | ||
| order: 10 | ||
| order: 12 |
Contributor
Author
There was a problem hiding this comment.
three different pages currently have order: 10, which isn't helpful for setting page order!
alexsobledotgov
commented
Nov 14, 2024
alexsobledotgov
changed the title
alexsobledotgov
requested review from
hbillings and
kewlguy781
and removed request for
a team
Contributor
Author
|
@kewlguy781 and @hbillings -- follow-on PR to #741 ready for your review |
kewlguy781
approved these changes
Nov 15, 2024
Contributor
kewlguy781
left a comment
kewlguy781
left a comment
There was a problem hiding this comment.
Look good to me. thanks for helping clean up this. We may want to communicate with the guides/TLC to keep eyes on the pages order navbar when adding new pages to the guides.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Preview link
Changes
This is a follow-on PR to #741 that adjusts a few things:
10Security considerations
N/A