Switch to eslint

.eslintignore

@@ -0,0 +1,3 @@
+node_modules/*
+lib/web/static/*
+coverage/*

.eslintrc.json

@@ -0,0 +1,26 @@
+{
+  "extends": "airbnb-base",
+  "rules": {
+    "class-methods-use-this": 0,
+    "comma-dangle": [
+      1,
+      "never"
+    ],
+    "max-len": 0,
+    "no-restricted-syntax": [
+      "error",
+      "LabeledStatement",
+      "WithStatement"
+    ],
+    "prefer-destructuring": [
+      "error",
+      {
+        "array": false,
+        "object": true
+      }
+    ]
+  },
+  "env": {
+    "node": true
+  }
+}

app.js

@@ -1,79 +1,71 @@
-'use strict';
-
 require('./env');
-var log = require('./getLogger')('app');
-var Botkit = require('botkit');
-var schedule = require('node-schedule');
-var botLib = require('./lib/bot');
-var startWebServer = require('./lib/web/start');
-var cfenv = require('cfenv');
-
-var appEnv = cfenv.getAppEnv();
+const log = require('./getLogger')('app');
+const Botkit = require('botkit');
+const schedule = require('node-schedule');
+const botLib = require('./lib/bot');
+const startWebServer = require('./lib/web/start');
 
 // Database setup
-var models = require('./models');
-models.sequelize.sync(
-  // Set to true to reset db on load
-  {force: false}
-);
+const models = require('./models');
+
+// Set to true to reset db on load
+models.sequelize.sync({ force: false });
 
 if (!process.env.SLACK_TOKEN) {
   log.error('SLACK_TOKEN not set in environment.');
   process.exit(1);
 }
 
-var bkLogger = require('./getLogger')('botkit');
-function bkLog(level) {
-  var args = [ ];
-  for(var i = 1; i < arguments.length; i++) {
-    args.push(arguments[i]);
-  }
+const bkLogger = require('./getLogger')('botkit');
 
+function bkLog(inLevel, ...args) {
   // Remap botkit log levels
-  if(level === 'debug') {
+  let level = inLevel;
+  if (level === 'debug') {
     return;
-  }
-  else if(level === 'info') {
+  } else if (level === 'info') {
     level = 'verbose';
-  } else if(level === 'notice') {
+  } else if (level === 'notice') {
     level = 'info';
   }
 
-  var fn, thisObj;
-  if(bkLogger[level]) {
+  let fn;
+  let thisObj;
+
+  if (bkLogger[level]) {
     fn = bkLogger[level];
     thisObj = bkLogger;
   } else {
-    fn = console.log;
+    fn = console.log; // eslint-disable-line no-console
     thisObj = console;
-    args.unshift('[' + level + ']');
+    args.unshift(`[${level}]`);
   }
 
   fn.apply(thisObj, args);
 }
 
-var controller = Botkit.slackbot({
+const controller = Botkit.slackbot({
   debug: false,
   logger: { log: bkLog },
   webserver: {
-    static_dir: __dirname + '/lib/web/static'
+    static_dir: `${__dirname}/lib/web/static`
   }
 });
 
 // Initialize the bot
 controller.spawn({
   token: process.env.SLACK_TOKEN,
   retry: 5
-}).startRTM(function(err, bot) {
-  if (err) {
-    log.error(err);
-    throw new Error(err);
+}).startRTM((startRTMerr, bot) => {
+  if (startRTMerr) {
+    log.error(startRTMerr);
+    throw new Error(startRTMerr);
   } else {
     log.info('Connected to RTM');
-    bot.identifyBot(function(err,identity) {
+    bot.identifyBot((identifyBotErr, identity) => {
       // identity contains...
       // {name, id, team_id}
-      log.info('Bot name: ' + identity.name);
+      log.info(`Bot name: ${identity.name}`);
 
       // Set up cron job to check every minute for channels that need a standup report
       schedule.scheduleJob('* * * * 1-5', botLib.getReportRunner(bot));

env.js

@@ -1,7 +1,8 @@
-'use strict';
+
 
 require('dotenv').config();
 const cfenv = require('cfenv');
+
 const appEnv = cfenv.getAppEnv();
 
 const knownEnvs = [

features/.eslintrc.json

@@ -0,0 +1,10 @@
+{
+  "rules": {
+    "import/no-extraneous-dependencies": ["error", { "devDependencies": true }]
+  },
+  "globals": {
+    "describe": false,
+    "it": false,
+    "beforeEach": false
+  }
+}