Skip to content
This repository was archived by the owner on Nov 14, 2019. It is now read-only.

fix errors setting up new database#157

Open
billneff79 wants to merge 1 commit into18F:developfrom
billneff79:fix-database-init
Open

fix errors setting up new database#157
billneff79 wants to merge 1 commit into18F:developfrom
billneff79:fix-database-init

Conversation

@billneff79
Copy link
Copy Markdown

Due to the order that the database migrations were being run in, a brand-new database setup would fail when running migrate-to-local-times because the model was trying to use a postUpdatesInChannel field that isn't present in the database yet. By changing the file names in this PR, the postUpdatesInChannel field gets added before it is used by ``migrate-to-local-times` and the databases get setup properly now, even on a fresh install

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #157 into develop will decrease coverage by 1.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #157     +/-   ##
==========================================
- Coverage    86.44%   85.15%   -1.3%     
==========================================
  Files           58       59      +1     
  Lines         1372     1374      +2     
  Branches       181      181             
==========================================
- Hits          1186     1170     -16     
- Misses         186      204     +18
Impacted Files Coverage Δ
lib/helpers/reports/forChannelUpdate.js 33.33% <0%> (-66.67%) ⬇️
lib/helpers/updateChannelReport.js 19.04% <0%> (-57.15%) ⬇️
lib/helpers/doChannelReport.js 94.73% <0%> (-5.27%) ⬇️
lib/helpers/doBlock.js 91.66% <0%> (-1.67%) ⬇️
models/index.js 92.85% <0%> (ø)
lib/helpers/reports/transformers/index.js 100% <0%> (+7.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c8b97a...a119a49. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants