feat: update some plugin#12709
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bf8083b1ed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| value="weCom" | ||
| v-if="!globalStore.isIntl" | ||
| :disabled="!globalStore.isProductPro" | ||
| :disabled="!globalStore.isXpackNodeOrEE" |
There was a problem hiding this comment.
isXpackNodeOrEE is a store method, so using !globalStore.isXpackNodeOrEE negates the function object and always evaluates to false. On non-Pro/non-EE, non-international nodes this leaves WeCom/DingTalk/FeiShu enabled in the alert-task dialog even though the prior isProductPro check disabled them, letting users select licensed-only alert methods.
Useful? React with 👍 / 👎.
| <el-card | ||
| class="rounded-2xl shadow hover:shadow-md transition-all" | ||
| v-if="globalStore.isProductPro && !globalStore.isIntl" | ||
| v-if="globalStore.isXpackNodeOrEE && !globalStore.isIntl" |
There was a problem hiding this comment.
isXpackNodeOrEE is defined as a function on the global store, so this v-if tests the function object itself and is always truthy whenever !globalStore.isIntl is true. That exposes the WeCom/DingTalk/FeiShu configuration cards to non-Pro/non-EE installations, whereas the previous isProductPro condition hid these licensed-only settings.
Useful? React with 👍 / 👎.
3 participants
No description provided.