Skip to content

Unreliable behavior when equip load strictly equals weight threshold. #7

Open

Description

@Corollax

At 40 vigor, player characters have 80 equipment load available. The tool reports 56.0 weight setups as satisfying the default 0.7 "fast roll" criteria, but Dark Souls 3 gives these players a slow roll.

Intuitively, the default setting should provide a fast roll for the 70% burden setting, and the tool should mirror the game's test "less than" criteria, rather than using "less than or equal to".

EDIT: It appears that this edge case is inconsistent, and depends on From's rounding algorithm. They should be using integer math if they're going to be testing inequalities, but this is very evidently not the case.

Activity

  1. 3dots commented on Jun 15, 2016

    @3dots
    Owner

    Are you 100% sure that literal equal condition never works? I'll check myself in a bit, but it seems odd that I haven't encountered this during the months I've been using it. I don't doubt your claim, maybe there's odd rounding going on.

  2. reopened this on Jun 15, 2016
  3. 3dots commented on Jun 15, 2016

    @3dots
    Owner

    Sry, accidentally closed.

  4. Corollax commented on Jun 16, 2016

    @Corollax
    Author

    I did some more testing. Unfortunately, the 70.0 result is inconsistent. I have two setups that reach 56.0 units of weight with my 80 load allowance. One can fast roll. The other cannot.

    If I select strictly pieces that are representable without loss in binary arithmetic (i.e. pieces with weight evenly divisible by 0.5), I get a fast roll. Maybe that helps.

  5. 3dots commented on Jun 16, 2016

    @3dots
    Owner

    roflmao, did they write their own floating arithmetic?

  6. 3dots commented on Jun 17, 2016

    @3dots
    Owner

    Hey, is there any chance my Data sets are wrong? There were rumors on r/darksouls3 about possible armor weight changes a few days back.

  7. Corollax commented on Jun 20, 2016

    @Corollax
    Author

    I suppose it's possible, but it'd be unrelated to this issue. Your calculator gave me exactly the weight the game calculated -- but the result of that calculation was inconsistent on the fast roll threshold, depending on the pieces I used to get there.

    Sorry if I'm being unhelpful or too critical. I really like your tool. Thanks for providing it.

  8. changed the title [-]Permitted weight total should be strictly less than the given threshold.[/-] [+]Unreliable behavior when equip load strictly equals weight threshold.[/+] on Jun 22, 2016
  9. 3dots commented on Jun 24, 2016

    @3dots
    Owner

    Ok, my suspicion is that they may be using float instead of double floating point precision. Can you post exact equipment choices you had that conflict with the <70% rule? If we try to compute the weight fraction using floats maybe that will reveal something.

  10. Corollax commented on Jul 5, 2016

    @Corollax
    Author

    For my testing, I equipped weapons with whole-integer weight until I had exactly 6.0 units of my 70% threshold left. So if you have 10 vitality (50 load), that's 35.0 units available. I spent 29.0 units of weight using only equipment that weighed a multiple of 1.0 units, leaving 6.0 units.

    With rings and gauntlets, I then spent my remaining weight:

    • Four Clutch rings + Gloves of Thorns:
      • (4 x 0.8) + 2.8 => FAST roll
    • Four Stoneplate rings + Sunless Gauntlets:
      • (4 x 0.6) + 3.6 => FAST roll
    • Three " boosting" rings + Sage ring + Dark Gauntlets:
      • (4 x 0.7) + 3.2 => SLOW roll

    " boosting" = Morne's Ring, Young Dragon Ring, Great Swamp Ring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions