Skip to content

Conversation

@eguzki
Copy link
Member

@eguzki eguzki commented Nov 23, 2021

For each 3scale Admin API call, the client was opening a new connection. For backwards compat, the default behavior will still be to open a new connection for each API call. But keep_alive new attr allows to keep connections open for multiple calls.

@codecov-commenter
Copy link

Codecov Report

Merging #104 (5475b70) into main (2cdce79) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
+ Coverage   99.65%   99.66%   +0.01%     
==========================================
  Files          12       12              
  Lines        1439     1495      +56     
==========================================
+ Hits         1434     1490      +56     
  Misses          5        5              
Impacted Files Coverage Δ
lib/3scale/api.rb 100.00% <100.00%> (ø)
lib/3scale/api/http_client.rb 97.56% <100.00%> (+0.19%) ⬆️
spec/api/http_client_spec.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cdce79...5475b70. Read the comment docs.

@eguzki eguzki merged commit 44ca860 into main Nov 23, 2021
@eguzki eguzki deleted the enable-keep-alive-connections branch November 23, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants