fix: Fix trying to access to just deleted measurement profile from edit window.

[Czaki]

fix PARTSEG-VE

Summary by CodeRabbit

• Bug Fixes
  • Improved the logic for validating selected items in the profile list to prevent errors related to deleted items.
  • Enhanced robustness of the application by accommodating edge cases in profile selection.

[coderabbitai]

Walkthrough

The recent changes enhance the profile_chosen method in advanced_window.py by improving the validation logic for selected profile items. The update ensures that the method accurately checks for both the presence of the selected item and its validity within the current measurement profiles. This adjustment addresses potential issues arising from recent deletions and enhances the robustness of the application's handling of profile selections.

Changes

Files	Change Summary
package/PartSeg/_roi_analysis/advanced_window.py	Enhanced profile_chosen method to improve item validity checks, preventing errors from deleted profiles.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant AdvancedWindow

    User->>AdvancedWindow: Select profile item
    AdvancedWindow->>AdvancedWindow: Check if item is None
    alt Item is None
        AdvancedWindow->>User: Show error message
    else Item is not None
        AdvancedWindow->>AdvancedWindow: Verify item in settings
        alt Item is valid
            AdvancedWindow->>User: Load profile description
        else Item is invalid
            AdvancedWindow->>User: Show error message
        end
    end

Loading

Poem

In the garden where profiles bloom,
A rabbit hops, dispelling gloom.
With checks in place, no errors arise,
Valid choices bring joyful sighs.
Hooray for code, so smart and neat,
A better world, oh, what a treat! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sourcery-ai]

🧙 Sourcery has finished reviewing your pull request!

---

Tips

• Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
• Continue your discussion with Sourcery by replying directly to review comments.
• You can change your review settings at any time by accessing your dashboard:
  • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
  • Change the review language;
• You can always contact us if you have any questions or feedback.

[sourcery-ai]

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 501574e and a8ea0a5.

Files selected for processing (1)

• package/PartSeg/_roi_analysis/advanced_window.py (1 hunks)

Additional comments not posted (1)

package/PartSeg/_roi_analysis/advanced_window.py (1)

536-538: Enhance the robustness of the profile selection logic.

The added condition ensures that the selected item is not only present but also valid within the current measurement profiles. This prevents errors when accessing recently deleted profiles.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.09%. Comparing base (501574e) to head (a8ea0a5).
Report is 43 commits behind head on develop.

Files with missing lines	Patch %	Lines
package/PartSeg/_roi_analysis/advanced_window.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #1168   +/-   ##
========================================
  Coverage    93.09%   93.09%           
========================================
  Files          209      209           
  Lines        32881    32881           
========================================
  Hits         30609    30609           
  Misses        2272     2272           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.