chore: Disable thumbnail generation in napari layer as it is fragile and not used#1171
chore: Disable thumbnail generation in napari layer as it is fragile and not used#1171
Conversation
|
🧙 Sourcery has finished reviewing your pull request! Tips
|
WalkthroughThis update introduces a private class, Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
|
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- package/PartSeg/common_gui/napari_image_view.py (2 hunks)
Additional comments not posted (2)
package/PartSeg/common_gui/napari_image_view.py (2)
63-66: LGTM!The
_NapariImageclass correctly inherits fromNapariImageand effectively disables the thumbnail update with the overridden_update_thumbnailmethod.
Line range hint
1081-1089:
LGTM!The
_prepare_layersfunction now correctly uses_NapariImageto disable thumbnail updates. This aligns with the PR objective.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1171 +/- ##
========================================
Coverage 93.09% 93.09%
========================================
Files 209 209
Lines 32881 32883 +2
========================================
+ Hits 30609 30611 +2
Misses 2272 2272 ☔ View full report in Codecov by Sentry. |



This PR uses a private API, but should not be fragile as change name of function will only enable again thumbnail generation.
Summary by CodeRabbit