Conversation
Contributor
Reviewer's Guide by SourceryThis pull request addresses the deprecation of Sequence diagram for napari application initializationsequenceDiagram
participant PartSeg
participant napari.qt
PartSeg->>napari.qt: try: get_qapp()
alt napari >= 0.5.4
napari.qt-->>PartSeg: Returns QApplication instance
else napari < 0.5.4
PartSeg->>napari.qt: except ImportError: get_app()
napari.qt-->>PartSeg: Returns QApplication instance
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
WalkthroughThis change updates the application initialization in the launcher. The Changes
Sequence Diagram(s)sequenceDiagram
participant Launcher as _test_imports
participant Napari as napari.qt Module
Launcher->>Napari: Import get_qapp
alt get_qapp available
Napari-->>Launcher: Return get_qapp
Launcher->>Launcher: Call get_qapp() to obtain app instance
else ImportError raised
Launcher->>Napari: Import get_app (alias as get_qapp)
Napari-->>Launcher: Return get_app
Launcher->>Launcher: Call get_qapp() (alias for get_app) to obtain app instance
end
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 300000ms (15)
🔇 Additional comments (2)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @Czaki - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Czaki
changed the title
get_qapp from get_app to handle napari deprecationget_qapp from get_app to handle napari deprecation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1249 +/- ##
========================================
Coverage 93.15% 93.15%
========================================
Files 210 210
Lines 33288 33288
========================================
Hits 31009 31009
Misses 2279 2279 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Enhancements:
get_qappand falling back toget_appfor older versions.Summary by CodeRabbit
personal_wsand added a new project entry forqapp.