chore: Block pytest-qt==4.5.0 (for pyside2 compatibility)#1282
Merged
chore: Block pytest-qt==4.5.0 (for pyside2 compatibility)#1282
pytest-qt==4.5.0 (for pyside2 compatibility)#1282Conversation
Contributor
Reviewer's GuideThis PR updates the project’s version denylist to prevent using pytest-qt 4.5.0, ensuring compatibility with PySide2. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
WalkthroughA new entry was added to the version denylist, specifically excluding version 4.5.0 of the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (29)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Czaki
changed the title
pytest-qt==4.5.0 (for pyside2 compatibility)
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
requirements/version_denylist.txt (1)
8-8: Add an inline rationale for future maintainersThe other entries in this file typically carry a short comment explaining why the specific version is blocked (e.g. PySide6 line 2). An inline note or link to the upstream issue that breaks PySide2 would save future readers a trip to the commit log.
-pytest-qt!=4.5.0 +pytest-qt!=4.5.0 # breaks PySide2 support – see https://github.com/pytest-dev/pytest-qt/issues/XXXXX
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
requirements/version_denylist.txt(1 hunks)
⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (14)
- GitHub Check: spellcheck
- GitHub Check: 4DNucleome.PartSeg (manifest_check manifest_check)
- GitHub Check: 4DNucleome.PartSeg (Documentation_check Notebook_check)
- GitHub Check: 4DNucleome.PartSeg (Documentation_check help)
- GitHub Check: 4DNucleome.PartSeg (GetTestData linux)
- GitHub Check: 4DNucleome.PartSeg (formatting_check check_formating)
- GitHub Check: spellcheck
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: Test latest release PySide2 / ubuntu-24.04 py 3.10 napari54 PySide2
- GitHub Check: Download test data
- GitHub Check: Test latest release PyQt5 / ubuntu-24.04 py 3.10 napari54 PyQt5
- GitHub Check: semgrep/ci
- GitHub Check: Analyze (python)
- GitHub Check: spellcheck
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1282 +/- ##
===========================================
+ Coverage 93.15% 93.17% +0.01%
===========================================
Files 210 210
Lines 33297 33297
===========================================
+ Hits 31018 31023 +5
+ Misses 2279 2274 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Chores:
Summary by CodeRabbit