chore: Use most recent macOS images on GitHub Actions#1310
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdate GitHub Actions workflows to use the latest macOS runner images (macos-15 and macos-15-intel) across all Python versions and Qt backend configurations. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
WalkthroughUpdates GitHub Actions workflow matrix to switch macOS runners from macos-13/14 to macos-15 and macos-15-intel in specified Python/Qt backend combinations across test jobs. Other OS targets and Python versions remain unchanged. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1310 +/- ##
===========================================
- Coverage 93.16% 93.15% -0.02%
===========================================
Files 210 210
Lines 33270 33271 +1
===========================================
- Hits 30996 30992 -4
- Misses 2274 2279 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/tests.yml (2)
58-61: macos-15-intel addition looks correct; Intel label is supported (note long‑term deprecation).The include for macOS Intel on Python 3.11/PyQt5 is valid. GitHub introduced the
macos-15-intellabel to support x86_64 workloads during macOS 13 retirement; plan eventual migration off Intel before 2027. (github.blog)If you also want Intel coverage on push runs, consider adding
macos-15-intelto the base-test-main OS list for parity.
96-99: Matrix OS updated to macos‑15: good pin.Using
macos-15explicitly (instead ofmacos-latest) avoids roll‑forward surprises while still aligning with GitHub’s migration. (github.blog)If you need Intel coverage on pushes, you could extend this OS list with
macos-15-intelas well.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/tests.yml(3 hunks)
⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (15)
- GitHub Check: 4DNucleome.PartSeg (Tests_other test windows)
- GitHub Check: 4DNucleome.PartSeg (Tests_other test macos)
- GitHub Check: 4DNucleome.PartSeg (Tests_linux test_linux)
- GitHub Check: 4DNucleome.PartSeg (Builds sdist)
- GitHub Check: 4DNucleome.PartSeg (Builds pyinstaller windows)
- GitHub Check: 4DNucleome.PartSeg (Builds pyinstaller macos_arm)
- GitHub Check: 4DNucleome.PartSeg (Builds pyinstaller_linux)
- GitHub Check: 4DNucleome.PartSeg (Builds pyinstaller macos)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: 4DNucleome.PartSeg (Documentation_check Notebook_check)
- GitHub Check: 4DNucleome.PartSeg (manifest_check manifest_check)
- GitHub Check: 4DNucleome.PartSeg (Documentation_check help)
- GitHub Check: 4DNucleome.PartSeg (formatting_check check_formating)
- GitHub Check: 4DNucleome.PartSeg (GetTestData linux)
- GitHub Check: Sourcery review
🔇 Additional comments (2)
.github/workflows/tests.yml (2)
61-64: Switch to macos‑15 (arm64) is spot on for PyQt6/py3.12.
macos-15is GA and the default formacos-latestsince Aug 2025, so pinning to 15 is stable and future‑proof. (github.com)
114-122: Excluding PySide2 and Python 3.9 on macos‑15 is prudent.
- Python <3.11 has known arm64 constraints on Actions runners; excluding 3.9 on
macos-15avoids setup issues. (github.com)- PySide2 has unresolved problems on macOS arm64; excluding it on
macos-15is sensible. (github.com)Please confirm your intent is to keep PySide2/macOS coverage only via non‑arm64 runners (e.g., Linux/Windows or macOS Intel).



Summary by Sourcery
CI:
Summary by CodeRabbit
Tests
Chores