Skip to content

chore: Use most recent macOS images on GitHub Actions#1310

Merged
Czaki merged 1 commit intodevelopfrom
bump-runners
Oct 1, 2025
Merged

chore: Use most recent macOS images on GitHub Actions#1310
Czaki merged 1 commit intodevelopfrom
bump-runners

Conversation

@Czaki
Copy link
Collaborator

@Czaki Czaki commented Oct 1, 2025

Summary by Sourcery

CI:

  • Update macos-13 and macos-14 runners to macos-15 and macos-15-intel across all Python and Qt backend configurations

Summary by CodeRabbit

  • Tests

    • Updated continuous integration test matrix to use newer macOS runners, improving reliability and coverage for current macOS environments and Qt backends.
    • Ensures consistent test execution across platforms while retaining existing Ubuntu and Windows coverage.
  • Chores

    • Aligned workflow configuration across jobs for consistency.
    • No changes to supported OSes or Python versions from an end-user perspective; no impact on application features or behavior.

@Czaki Czaki added this to the 0.16.4 milestone Oct 1, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 1, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Update GitHub Actions workflows to use the latest macOS runner images (macos-15 and macos-15-intel) across all Python versions and Qt backend configurations.

File-Level Changes

Change Details Files
Upgrade macOS images in test workflows
  • Replace macos-13 with macos-15-intel for Python 3.11 PyQt5 job
  • Replace macos-14 with macos-15 for Python 3.12 PyQt6 job
  • Update matrix os entries from macos-14 to macos-15
  • Change PySide2 macOS test entries from macos-14 to macos-15
.github/workflows/tests.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 1, 2025

Walkthrough

Updates GitHub Actions workflow matrix to switch macOS runners from macos-13/14 to macos-15 and macos-15-intel in specified Python/Qt backend combinations across test jobs. Other OS targets and Python versions remain unchanged.

Changes

Cohort / File(s) Summary
CI workflow macOS runner updates
​.github/workflows/tests.yml
Replaced macos-13/macos-14 with macos-15 and macos-15-intel in matrix entries (base-test, base-test-main, include/exclude) for PyQt5 (Py 3.11) and PyQt6 (Py 3.12). Ubuntu and Windows entries unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

A hop to fifteen, swift and spry,
Our runners race beneath the sky.
Intel here, a silicon breeze—
The matrix maps with graceful ease.
I twitch my nose, CI complies,
Green lights blink like fireflies. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly describes the primary change of switching to the most recent macOS images in the GitHub Actions workflow, aligning precisely with the modifications made to the tests.yml configuration.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bump-runners

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 1, 2025

@Czaki Czaki changed the title chore: Use most recent macos images on GHA chore: Use most recent macOS images on GHA Oct 1, 2025
@Czaki Czaki changed the title chore: Use most recent macOS images on GHA chore: Use most recent macOS images on GitHub Actions Oct 1, 2025
@codecov
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.15%. Comparing base (f8bbe49) to head (12ae036).
⚠️ Report is 34 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1310      +/-   ##
===========================================
- Coverage    93.16%   93.15%   -0.02%     
===========================================
  Files          210      210              
  Lines        33270    33271       +1     
===========================================
- Hits         30996    30992       -4     
- Misses        2274     2279       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.github/workflows/tests.yml (2)

58-61: macos-15-intel addition looks correct; Intel label is supported (note long‑term deprecation).

The include for macOS Intel on Python 3.11/PyQt5 is valid. GitHub introduced the macos-15-intel label to support x86_64 workloads during macOS 13 retirement; plan eventual migration off Intel before 2027. (github.blog)

If you also want Intel coverage on push runs, consider adding macos-15-intel to the base-test-main OS list for parity.


96-99: Matrix OS updated to macos‑15: good pin.

Using macos-15 explicitly (instead of macos-latest) avoids roll‑forward surprises while still aligning with GitHub’s migration. (github.blog)

If you need Intel coverage on pushes, you could extend this OS list with macos-15-intel as well.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6844249 and 12ae036.

📒 Files selected for processing (1)
  • .github/workflows/tests.yml (3 hunks)
⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (15)
  • GitHub Check: 4DNucleome.PartSeg (Tests_other test windows)
  • GitHub Check: 4DNucleome.PartSeg (Tests_other test macos)
  • GitHub Check: 4DNucleome.PartSeg (Tests_linux test_linux)
  • GitHub Check: 4DNucleome.PartSeg (Builds sdist)
  • GitHub Check: 4DNucleome.PartSeg (Builds pyinstaller windows)
  • GitHub Check: 4DNucleome.PartSeg (Builds pyinstaller macos_arm)
  • GitHub Check: 4DNucleome.PartSeg (Builds pyinstaller_linux)
  • GitHub Check: 4DNucleome.PartSeg (Builds pyinstaller macos)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: 4DNucleome.PartSeg (Documentation_check Notebook_check)
  • GitHub Check: 4DNucleome.PartSeg (manifest_check manifest_check)
  • GitHub Check: 4DNucleome.PartSeg (Documentation_check help)
  • GitHub Check: 4DNucleome.PartSeg (formatting_check check_formating)
  • GitHub Check: 4DNucleome.PartSeg (GetTestData linux)
  • GitHub Check: Sourcery review
🔇 Additional comments (2)
.github/workflows/tests.yml (2)

61-64: Switch to macos‑15 (arm64) is spot on for PyQt6/py3.12.

macos-15 is GA and the default for macos-latest since Aug 2025, so pinning to 15 is stable and future‑proof. (github.com)


114-122: Excluding PySide2 and Python 3.9 on macos‑15 is prudent.

  • Python <3.11 has known arm64 constraints on Actions runners; excluding 3.9 on macos-15 avoids setup issues. (github.com)
  • PySide2 has unresolved problems on macOS arm64; excluding it on macos-15 is sensible. (github.com)

Please confirm your intent is to keep PySide2/macOS coverage only via non‑arm64 runners (e.g., Linux/Windows or macOS Intel).

@Czaki Czaki merged commit 33e61cd into develop Oct 1, 2025
61 of 64 checks passed
@Czaki Czaki deleted the bump-runners branch October 1, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments