Skip to content

Minor updates for C++ generator #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewmd5 merged 2 commits into from
Jan 18, 2026
Merged

Minor updates for C++ generator #381

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7cac1b
Added missing constness for encodeInto for unions
roman380 Jan 16, 2026
a1c6382
Added missing (coalesced) line endings
roman380 Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Core/Generators/CPlusPlus/CPlusPlusGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System;
using System;
using System.Collections.Generic;
using System.IO;
using System.Linq;
Expand Down Expand Up @@ -455,8 +455,8 @@ public override ValueTask<Artifact[]> Compile(BebopSchema schema, GeneratorConfi
builder.AppendLine(" return after - before;");
builder.AppendLine(" }");
builder.AppendLine("");
builder.AppendLine($" size_t encodeInto(std::vector<uint8_t>& targetBuffer) {{ return {td.Name}::encodeInto(*this, targetBuffer); }}");
builder.AppendLine($" size_t encodeInto(::bebop::Writer& writer) {{ return {td.Name}::encodeInto(*this, writer); }}");
builder.AppendLine($" size_t encodeInto(std::vector<uint8_t>& targetBuffer) const {{ return {td.Name}::encodeInto(*this, targetBuffer); }}");
builder.AppendLine($" size_t encodeInto(::bebop::Writer& writer) const {{ return {td.Name}::encodeInto(*this, writer); }}");
builder.AppendLine("");
builder.AppendLine($" static {td.Name} decode(const uint8_t* sourceBuffer, size_t sourceBufferSize) {{");
builder.AppendLine($" {td.Name} result;");
Expand Down Expand Up @@ -485,6 +485,7 @@ public override ValueTask<Artifact[]> Compile(BebopSchema schema, GeneratorConfi
builder.AppendLine("");
builder.AppendLine($" static size_t decodeInto(::bebop::Reader& reader, {td.Name}& target) {{");
builder.Append(CompileDecode(td));
builder.AppendLine("");
builder.AppendLine(" return reader.bytesRead();");
builder.AppendLine(" }");
builder.AppendLine("");
Expand Down
Loading