Skip to content

Support .netstandard2.1#35

Merged
gldeng merged 11 commits intodevfrom
feature/netstand2.1
Oct 2, 2023
Merged

Support .netstandard2.1#35
gldeng merged 11 commits intodevfrom
feature/netstand2.1

Conversation

@gldeng
Copy link
Copy Markdown
Collaborator

@gldeng gldeng commented Jun 27, 2023

No description provided.

@vizipi
Copy link
Copy Markdown

vizipi bot commented Jun 27, 2023

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

No other active qualified developers found to review these specific changes. You might consider involving more team members with these code segments.


Potential missing files from this Pull request

No files found with a 40% threashold :)
No commonly committed files found with a 40% threashold

zhifenglee-aelf added 2 commits June 28, 2023 17:52
Comment thread src/AElf.Client/Services/HttpService.cs Outdated
Comment thread src/AElf.Client.Protobuf/AElf.Client.Protobuf.csproj Outdated
Comment thread src/AElf.Client.Protobuf/AElf.Client.Protobuf.csproj Outdated
@argfoo-web3
Copy link
Copy Markdown

Build will fail due to 1.3.0 for AElf.Cryptography and AElf.Types not supporting .Net Standard 2.1. We will need to make sure we create a new nuget version for this PR (AElfProject/AElf#3433) first before we merge this.

@arg-foo arg-foo changed the title [WIP] Support .netstandard2.1 Support .netstandard2.1 Aug 29, 2023
@gldeng gldeng merged commit 3dcbf53 into dev Oct 2, 2023
@delete-merged-branch delete-merged-branch bot deleted the feature/netstand2.1 branch October 2, 2023 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants