add NSE network compatibility docs#1852
Merged
zingale merged 3 commits intoAMReX-Astro:developmentfrom Sep 30, 2025
Merged
Conversation
Member
Author
|
addresses #1834 it is not clear to me if the NSE compatibility script works in the case that the network has weak rates that change Ye |
Collaborator
|
I think it might work if the weak rates are slow so that dYedt is very small then the state reaches NSE whenever it switches to a slightly different Ye? I haven't tested, but technically this test is meant to use for networks without weak rates. |
Member
Author
|
okay, that's what I figured. I will update the comment to reflect this in a bit. We should provide a way to disable weak rates in pynucastro nets for testing. |
Member
Author
|
I've updates the docs to mention Ye evolution |
zhichen3
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.