Conversation
|
|
📝 WalkthroughWalkthroughThe layout component's inner container had the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
3 similar comments
|
|
|
|
|
|
|
@Himani78116 Thanks for the suggestions! I’ve updated the PR #941 accordingly and cleaned it up based on the feedback. |
The minimal one-line change was sufficient here. I initially over-scoped the fix while exploring the codepath. |
Thanks for the clarification. Since the issue is already assigned to you, I'll step back on this to avoid duplication. Appreciate the review and guidance. |
Fixes #941
Problem:
When the window was maximized, two vertical scrollbars appeared, causing confusing UX and layout overflow.
Cause:
The issue was caused by nested containers applying "overflow-y-auto" simultaneously, resulting in multiple scroll contexts.
Solution:
Removed redundant overflow handling and ensured a single scroll container at the layout level.
Result:
Scroll behavior is now consistent across window sizes with a single scrollbar.
Before:
https://github.com/user-attachments/assets/44a31e0d-a618-48b0-a634-9f798818b9cc
After:
https://github.com/user-attachments/assets/328601f9-d69a-438e-ae3a-035d3047ea4e
I've included before and after recordings to clearly demonstrate the issue and the fix. Please let me know if you'd like the solution
handled differently or split further.