-
-
Notifications
You must be signed in to change notification settings - Fork 618
feat: Add pagination support for image gallery API #1067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
alishair7071
wants to merge
1
commit into
AOSSIE-Org:main
from
alishair7071:feat/add-pagination-support
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: AOSSIE-Org/PictoPy
Length of output: 92
🏁 Script executed:
Repository: AOSSIE-Org/PictoPy
Length of output: 2254
🏁 Script executed:
Repository: AOSSIE-Org/PictoPy
Length of output: 551
🏁 Script executed:
Repository: AOSSIE-Org/PictoPy
Length of output: 3287
🏁 Script executed:
Repository: AOSSIE-Org/PictoPy
Length of output: 3613
🏁 Script executed:
Repository: AOSSIE-Org/PictoPy
Length of output: 4576
🏁 Script executed:
Repository: AOSSIE-Org/PictoPy
Length of output: 1209
Guard against partial pagination params to avoid unexpected full fetches.
If a client sends only
pageor onlylimitwithout both parameters, the function silently falls back to returning all images. This defeats the purpose of pagination and can reintroduce the large-response risk. Bothpageandlimitshould be required together or explicitly default; partial pagination parameters should not be silently accepted.Consider rejecting requests with mismatched parameters:
Suggested validation
def get_all_images( tagged: Optional[bool] = Query(None, description="Filter images by tagged status"), page: Optional[int] = Query(None, ge=1, description="Page number (1-indexed)"), limit: Optional[int] = Query( None, ge=1, le=100, description="Number of images per page (max 100)" ), ): """ Get all images from the database. - If `page` and `limit` are provided, returns paginated results. - If `page` and `limit` are not provided, returns all images (backward compatible). """ try: + if (page is None) ^ (limit is None): + raise HTTPException( + status_code=status.HTTP_400_BAD_REQUEST, + detail="Both 'page' and 'limit' must be provided together.", + ) # Get images with optional pagination result = db_get_all_images(tagged=tagged, page=page, limit=limit)🤖 Prompt for AI Agents