Skip to content

fix: improve exception handling in database connection #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
riyagoyal01 wants to merge 1 commit into from
Closed

fix: improve exception handling in database connection #1151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion backend/app/database/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
import sqlite3
import logging
from contextlib import contextmanager
from typing import Generator
from app.config.settings import DATABASE_PATH

logger = logging.getLogger(__name__)

@contextmanager
def get_db_connection() -> Generator[sqlite3.Connection, None, None]:
Expand All @@ -25,7 +27,8 @@ def get_db_connection() -> Generator[sqlite3.Connection, None, None]:
try:
yield conn
conn.commit()
except Exception:
except sqlite3.Error:
logger.exception("Database error occurred while handling transaction")
conn.rollback()
raise
finally:
Expand Down