Skip to content

fixed progress bar overflow in onboarding steps #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rahulharpal1603 merged 2 commits into from
Dec 28, 2025
Merged

fixed progress bar overflow in onboarding steps #726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75bc9ff
fixed progress bar overflow in onboarding steps
Garry400 Dec 13, 2025
609c097
Fix className syntax for avatar selection button
rahulharpal1603 Dec 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions frontend/src/components/OnboardingSteps/AvatarSelectionStep.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,13 @@ import { AppFeatures } from '@/components/OnboardingSteps/AppFeatures';
interface AvatarNameSelectionStepProps {
stepIndex: number;
totalSteps: number;
currentStepDisplayIndex: number;
}

export const AvatarSelectionStep: React.FC<AvatarNameSelectionStepProps> = ({
stepIndex,
totalSteps,
currentStepDisplayIndex,
}) => {
const dispatch = useDispatch();

Expand Down Expand Up @@ -65,14 +67,18 @@ export const AvatarSelectionStep: React.FC<AvatarNameSelectionStepProps> = ({
<CardHeader className="p-3">
<div className="text-muted-foreground mb-1 flex justify-between text-xs">
<span>
Step {stepIndex + 1} of {totalSteps}
Step {currentStepDisplayIndex + 1} of {totalSteps}
</span>
<span>
{Math.round(((currentStepDisplayIndex + 1) / totalSteps) * 100)}%
</span>
<span>{Math.round(((stepIndex + 1) / totalSteps) * 100)}%</span>
</div>
<div className="bg-muted mb-2 h-1.5 w-full rounded-full">
<div
className="bg-primary h-full rounded-full transition-all duration-300"
style={{ width: `${((stepIndex + 1) / totalSteps) * 100}%` }}
style={{
width: `${((currentStepDisplayIndex + 1) / totalSteps) * 100}%`,
}}
/>
</div>
<CardTitle className="mt-1 text-xl font-semibold">
Expand Down
8 changes: 6 additions & 2 deletions frontend/src/components/OnboardingSteps/FolderSetupStep.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,13 @@ import { useEffect, useState } from 'react';
interface FolderSetupStepProps {
stepIndex: number;
totalSteps: number;
currentStepDisplayIndex: number;
}

export function FolderSetupStep({
stepIndex,
totalSteps,
currentStepDisplayIndex,
}: FolderSetupStepProps) {
const dispatch = useDispatch<AppDispatch>();

Expand Down Expand Up @@ -64,15 +66,17 @@ export function FolderSetupStep({
if (localStorage.getItem('folderChosen') === 'true') {
return null;
}
const progressPercent = Math.round(((stepIndex + 1) / totalSteps) * 100);
const progressPercent = Math.round(
((currentStepDisplayIndex + 1) / totalSteps) * 100,
);

return (
<>
<Card className="flex max-h-full w-1/2 flex-col border p-4">
<CardHeader className="p-3">
<div className="text-muted-foreground mb-1 flex justify-between text-xs">
<span>
Step {stepIndex + 1} of {totalSteps}
Step {currentStepDisplayIndex + 1} of {totalSteps}
</span>
<span>{progressPercent}%</span>
</div>
Expand Down
3 changes: 3 additions & 0 deletions frontend/src/components/OnboardingSteps/OnboardingStep.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,12 @@ export const OnboardingStep: React.FC<OnboardingStepProps> = ({
stepIndex,
stepName,
}) => {
const visibleStepIndex = VISIBLE_STEPS.indexOf(stepName);

const sharedProps = {
stepIndex,
totalSteps: VISIBLE_STEPS.length,
currentStepDisplayIndex: visibleStepIndex,
};

const renderStepComponent = () => {
Expand Down
8 changes: 6 additions & 2 deletions frontend/src/components/OnboardingSteps/ThemeSelectionStep.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,13 @@ import { useTheme } from '@/contexts/ThemeContext';
interface ThemeSelectionStepProps {
stepIndex: number;
totalSteps: number;
currentStepDisplayIndex: number;
}

export const ThemeSelectionStep: React.FC<ThemeSelectionStepProps> = ({
stepIndex,
totalSteps,
currentStepDisplayIndex,
}) => {
const { setTheme, theme } = useTheme();
const dispatch = useDispatch<AppDispatch>();
Expand All @@ -51,14 +53,16 @@ export const ThemeSelectionStep: React.FC<ThemeSelectionStepProps> = ({
return null;
}

const progressPercent = Math.round(((stepIndex + 1) / totalSteps) * 100);
const progressPercent = Math.round(
((currentStepDisplayIndex + 1) / totalSteps) * 100,
);
return (
<>
<Card className="flex max-h-full w-1/2 flex-col border p-4">
<CardHeader className="p-3">
<div className="text-muted-foreground mb-1 flex justify-between text-xs">
<span>
Step {stepIndex + 1} of {totalSteps}
Step {currentStepDisplayIndex + 1} of {totalSteps}
</span>
<span>{progressPercent}%</span>
</div>
Expand Down
Loading