Add support for Apple Log to the ACES OCIO config generator#125
Add support for Apple Log to the ACES OCIO config generator#125KelSolaar merged 10 commits intoAcademySoftwareFoundation:mainfrom
Conversation
Signed-off-by: Joseph Goldstone <jgoldstone@arri.com>
Signed-off-by: Joseph Goldstone <jgoldstone@arri.com>
Signed-off-by: Joseph Goldstone <jgoldstone@arri.com>
5a8745b to
f59fe47
Compare
Signed-off-by: Joseph Goldstone <jgoldstone@arri.com>
Signed-off-by: Joseph Goldstone <jgoldstone@arri.com>
Signed-off-by: Joseph Goldstone <jgoldstone@arri.com>
Signed-off-by: Joseph Goldstone <jgoldstone@arri.com>
|
Thanks @JGoldstone, I think we would need to do a few things here for that one to work:
[[tool.poetry.source]]
name = "test-pypi"
url = "https://test.pypi.org/simple/"
priority = "explicit"
[tool.poetry.dependencies]
opencolorio = {version = ">= 2, < 3", source = "test-pypi"} |
|
Thanks for adding this @JGoldstone ! As Thomas wrote, the .csv file is not supposed to be edited by the PRs. People are supposed to edit the Google Sheet, and then the .csv is exported from that. https://docs.google.com/spreadsheets/d/1nE95DEVtxtEkcIEaJk0WekyEH0Rcs8z_3fdwUtqP8V4/edit#gid=0 |
|
Thanks @doug-walker ! Is that to say, then, that the changes to the Google Sheet aren't version-controlled per se, with a formal review process, because they are indirectly reviewed through the derived CSV and typically are small enough so that they could be backed out easily? (Or perhaps version control exists for Google Sheets now...) I will make the change to the Sheet when I get into work, refresh the local CSV from that, test and resubmit. There is still an issue with the macOS-latest runner being unable to find Python 3.9 or 3.10. Not sure what that's about… |
|
I don't have write access to the sheet. Could I ask someone who does to look this change over and if it seems good, enter it and save it? Proposed changes: above current row 180, add: Above current line 185, add: "CG Config - Mapping" sheet (no change) Studio Config - Mapping sheet Above line 7, add: and just below that, add: Thanks very much. |
Signed-off-by: Joseph Goldstone <jgoldstone@arri.com>
|
Suggested change to pyproject.toml made, committed and pushed. |
|
Thank you Joseph! I made the change to the spreadsheet you requested, please let me know if you see any issues. (Note that the Studio config gets updated automatically. And note that there will be an alias generated automatically by the script, so we could discuss later if we want to modify or add to that.) |
KelSolaar
left a comment
There was a problem hiding this comment.
Let's merge this one, I will do any post-merge fixes.
With these changes I am able to load the generated config into ocioview, and load an image from my iPhone 15 Pro Max, and apply a standard ACES SDR for 709 rendering and ... I think is rendering correctly ... but I am a programmer, and play a color scientist on TV, and most decidedly am not a cinematographer.
I would greatly appreciate someone trying this out with 'known good' Apple Log test material.
The docker variants of things are untested because I don't know docker at all.