-
Notifications
You must be signed in to change notification settings - Fork 240
[scheduler/cuebot/pycue/rqd/pyoutline] Booking by Slot #2115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DiegoTavares
wants to merge
30
commits into
AcademySoftwareFoundation:master
Choose a base branch
from
DiegoTavares:slot-based-scheduling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
8143764
Add int_concurrent_frames_limit to host
DiegoTavares b30c886
[scheduler/cuebot] Introduce booking by slot to scheduler
DiegoTavares cfe2366
Add Layer Slots Required Field
DiegoTavares 769d8ef
Add slots_required field to layer in OpenCue DTD and PyOutline layer
DiegoTavares b3b90cf
[rework] Handle hardcoded values
DiegoTavares 4cee5d0
Clean up warning from rust modules
DiegoTavares 02b1f20
[pycue/cuegui/cuebot] Add concurrent_procs_limit
DiegoTavares ed316e1
Rename concurrent_procs to concurrent slots
DiegoTavares 73212de
Merge branch 'master' into slot-based-scheduling
DiegoTavares 33acb5c
Minor fixes
DiegoTavares 2ad42b4
Revert re-formatting
DiegoTavares db53152
Fix formatting
DiegoTavares de7b26c
Fix formatting
DiegoTavares d6888ee
Add slots_required to rqd.RunFrame
DiegoTavares 19791d0
Implement slot based booking on rqd
DiegoTavares fb4172a
spotless Apply
DiegoTavares e7bc337
Add slots_required to LayerMonitorTree
DiegoTavares 9729954
Add slots required configuration to LayerDialog
DiegoTavares 3bbd8e9
Merge branch 'master' into slot-based-scheduling
DiegoTavares cb61fd7
Update documentation
DiegoTavares 14fc0d1
Version Up
DiegoTavares e984bef
Fix migration id
DiegoTavares 74ebcad
Fix python linting
DiegoTavares 192e2bf
Fix review comments
DiegoTavares 38bdeda
Improve required_slots accounting
DiegoTavares 091a98b
Add runningSlots tracking to Host and display available slots in GUI
DiegoTavares 45bc449
Fix cicd
DiegoTavares ea5a80e
Fix tests and spotless errors
DiegoTavares 49ea65d
Merge branch 'master' into slot-based-scheduling
DiegoTavares 6b97a04
Fix issue identified on the last review pass
DiegoTavares File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 1.17 | ||
| 1.18 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Race condition on slot overbooking
The
runningSlotsvalue is set from host reports (periodic). Concurrent dispatcher threads can read the same stale count and both book a frame, exceeding the limit. This needs database-level locking (SELECT ... FOR UPDATE) or atomic compare-and-update.