8.2.1#2426
Merged
Merged
Conversation
…ed-does-not-give-clear-explanation bug/2416 show detailed error message when deleting dataExtension field fails
…annot-be-saved-if-too-many-des-are-found bug/2418 throttle saving markdown files for automation and dataExtension
…asset-message bug/2424 fix 8.2.0 regression in cdp that prevents asset-message from being found
…is-incorrect-in-update-response Bug/2337 journey created date is incorrect in update response
Coverage ReportCommit:ae5564fBase: main@3d4c4ca
Details (changed files):
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This release PR (version 8.2.1) addresses several bug fixes including Journey createdDate handling, asset message block path parsing, DataExtension field deletion error handling, and documentation generation performance improvements.
- Fixed Journey.postDeployTasks to preserve correct createdDate from cache instead of using incorrect date from API update response
- Enhanced devops.js to handle asset message block file paths with additional folder levels
- Improved DataExtensionField error message handling to support alternative error response formats
- Added concurrency limiting (100 concurrent operations) to DataExtension and Automation document generation to prevent performance issues
Reviewed Changes
Copilot reviewed 9 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/metadataTypes/Journey.js | Overrides incorrect createdDate from API response with cached value in postDeployTasks |
| lib/util/devops.js | Removes obsolete comment and adds fallback logic for extracting externalKey from asset message block paths |
| lib/metadataTypes/DataExtensionField.js | Enhances error message extraction to handle ex.json.Results format and adds optional chaining |
| lib/metadataTypes/DataExtension.js | Adds pLimit(100) concurrency control to document generation operations |
| lib/metadataTypes/Automation.js | Adds pLimit(100) concurrency control to document generation operations |
| test/resources/.../put-response*.json | Updates test fixtures to use placeholder createdDate value (0001-01-01T00:00:00) |
| @types/**/*.d.ts.map | Updates TypeScript type definition source maps (auto-generated) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release details
Checklist
Before merge
npm run prepare-release(which runsnpm audit fix,npm run lint-ts,npm run lint:fix,git add,git commit)After merge
npm run version:major/minor/patchDocumentation
... insert updated documentation here ...
Issues