Skip to content

[checkout] Code generation: update services and models#1644

Open
AdyenAutomationBot wants to merge 1 commit intomainfrom
sdk-automation/checkout
Open

[checkout] Code generation: update services and models#1644
AdyenAutomationBot wants to merge 1 commit intomainfrom
sdk-automation/checkout

Conversation

@AdyenAutomationBot
Copy link
Copy Markdown
Collaborator

This PR contains the automated changes for the checkout service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot AdyenAutomationBot requested review from a team as code owners March 25, 2026 11:06
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the checkout service models and introduces new payment method details, reflecting recent changes from the adyen-openapi specification. The changes include adding new payment method models, enhancing existing API models with new fields and improved descriptions, and refining data structures for better clarity and accuracy.

Highlights

  • New Payment Method Models: Introduced AlmaDetails, DirectDebitAuDetails, and KlarnaNetworkDetails to support new payment options.
  • API Model Enhancements: Existing models like CheckoutForwardRequest, DonationCampaignsRequest, DonationPaymentRequest, PaymentRequest, StoredPaymentMethodResource, and TokenMandate received new fields and updated descriptions to support expanded functionality.
  • Data Structure Refinements: The InvalidField and ShopperTaxInfo models were restructured for clarity and accuracy.
  • Enum Updates: Added new enum values and reordered existing ones in PaymentDetails, PlatformChargebackLogic, and Result to reflect updated payment types and processing logic.
  • Metadata Additions: ResponseAdditionalDataCard and ResponseAdditionalDataCommon now include additional card and network processing information.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new payment method details for Alma, Direct Debit AU, and Klarna Network, along with their respective model definitions and updates to the objectSerializer to include these new types. It also adds new fields such as amount to CheckoutForwardRequest, store to donation-related requests, cardAltID to ResponseAdditionalDataCard, and networkProcessingMode to ResponseAdditionalDataCommon. Additionally, several documentation comments have been refined for clarity, and new properties like minAmount, recurringAmount, recurringStatement, and retryPolicy have been added to TokenMandate. A review comment highlighted an issue in objectSerializer.ts where individual enum values were incorrectly added to enumsMap instead of the enum type name, specifically for the Result enum.

Result.Valid,
Result.Invalid,
Result.Unknown,
Result.NotRequired,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The enumsMap is intended to store the string names of enum types (e.g., "Result"), not their values. Adding individual enum members like Result.NotRequired is incorrect because it adds the value 'NOT_REQUIRED' to the set, while the serializer logic checks for the type name "Result".

This and the other Result.* entries should be removed and replaced with a single entry: "Result".

Since I can only suggest a change for this line, I'm suggesting its removal. Please also remove the other Result values from this map and add "Result" to ensure the Result enum is handled correctly and consistently.

@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/checkout branch 4 times, most recently from e19f0d2 to ec2c572 Compare April 1, 2026 09:31
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/checkout branch from ec2c572 to a251e48 Compare April 2, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant