[checkout] Code generation: update services and models#1644
[checkout] Code generation: update services and models#1644AdyenAutomationBot wants to merge 1 commit intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces new payment method details for Alma, Direct Debit AU, and Klarna Network, along with their respective model definitions and updates to the objectSerializer to include these new types. It also adds new fields such as amount to CheckoutForwardRequest, store to donation-related requests, cardAltID to ResponseAdditionalDataCard, and networkProcessingMode to ResponseAdditionalDataCommon. Additionally, several documentation comments have been refined for clarity, and new properties like minAmount, recurringAmount, recurringStatement, and retryPolicy have been added to TokenMandate. A review comment highlighted an issue in objectSerializer.ts where individual enum values were incorrectly added to enumsMap instead of the enum type name, specifically for the Result enum.
| Result.Valid, | ||
| Result.Invalid, | ||
| Result.Unknown, | ||
| Result.NotRequired, |
There was a problem hiding this comment.
The enumsMap is intended to store the string names of enum types (e.g., "Result"), not their values. Adding individual enum members like Result.NotRequired is incorrect because it adds the value 'NOT_REQUIRED' to the set, while the serializer logic checks for the type name "Result".
This and the other Result.* entries should be removed and replaced with a single entry: "Result".
Since I can only suggest a change for this line, I'm suggesting its removal. Please also remove the other Result values from this map and add "Result" to ensure the Result enum is handled correctly and consistently.
e19f0d2 to
ec2c572
Compare
ec2c572 to
a251e48
Compare
This PR contains the automated changes for the
checkoutservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.