Skip to content

feat: update examples with writeback and webhook integration#10

Merged
khaliqgant merged 6 commits intomainfrom
feat/update-examples
Mar 29, 2026
Merged

feat: update examples with writeback and webhook integration#10
khaliqgant merged 6 commits intomainfrom
feat/update-examples

Conversation

@khaliqgant
Copy link
Copy Markdown
Member

@khaliqgant khaliqgant commented Mar 29, 2026

Updates adapter examples with writeback support, webhook handling, and GitHub adapter integration. Replaces #5.


Open with Devin

devin-ai-integration[bot]

This comment was marked as resolved.

@khaliqgant khaliqgant force-pushed the feat/update-examples branch from be496ef to b72a923 Compare March 29, 2026 20:31
@khaliqgant khaliqgant merged commit 745950c into main Mar 29, 2026
1 check passed
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 new potential issues.

View 10 additional findings in Devin Review.

Open in Devin Review

"types": "dist/src/index.d.ts",
"bin": {
"adapter-core": "./dist/src/cli.js"
"adapter-core": "./dist/cli.js"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 CLI bin path points to wrong location after rootDir change

The bin entry was changed from ./dist/src/cli.js to ./dist/cli.js, but the tsconfig.json rootDir was simultaneously changed from "src" to "." (packages/core/tsconfig.json). With rootDir: "." and outDir: "dist", src/cli.ts compiles to dist/src/cli.js — so the old path was actually correct for the new config. The main field was correctly updated to dist/src/index.js, but the bin field was changed in the opposite direction. Running npx adapter-core will fail with a "file not found" error because dist/cli.js won't exist.

Suggested change
"adapter-core": "./dist/cli.js"
"adapter-core": "./dist/src/cli.js"
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Comment on lines +158 to +160
## Mapping YAML Specification

See [docs/MAPPING_YAML_SPEC.md](docs/MAPPING_YAML_SPEC.md) for the formal specification of the mapping YAML format used by `@relayfile/adapter-core`.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Duplicate "Mapping YAML Specification" section in README

The PR adds a second identical "## Mapping YAML Specification" heading and link at lines 158–160 of README.md, immediately below the existing one at lines 154–156. This creates a duplicate section in the rendered documentation.

Suggested change
## Mapping YAML Specification
See [docs/MAPPING_YAML_SPEC.md](docs/MAPPING_YAML_SPEC.md) for the formal specification of the mapping YAML format used by `@relayfile/adapter-core`.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant