Conversation
59fcb74 to
f3c70b4
Compare
1284f64 to
641d38e
Compare
641d38e to
03d9e36
Compare
03d9e36 to
efe7dce
Compare
|
See also nodejs/node#48890 |
ff5ba9e to
9443819
Compare
9443819 to
8b88047
Compare
8b88047 to
ef3b2a4
Compare
ef3b2a4 to
c4116e9
Compare
c4116e9 to
03999ed
Compare
03999ed to
a023b50
Compare
7456ba3 to
f0f4290
Compare
|
nvm my earlier (deleted) comment about the CI failure. It seems a perfect specimen of the |
94c6cbf to
531eb51
Compare
ea1aa1c to
2a47191
Compare
fa82f4b to
9a47f38
Compare
|
Hi @michaelfig , this is Ready for Review. |
|
@michaelfig , could you take a look at the failing integration tests? Thanks. |
This has been bumped up in my queue. I ground to a halt the last time I tried; with fresh eyes I should get it done this week. |
|
@erights, I pushed some changes to restore some of the logging default behaviour. This was to cause silencing (using the Let's see this pass CI, then I will review again. |
9a47f38 to
3a6cd01
Compare
It passed, thanks much! |
7de259b to
afcb935
Compare
afcb935 to
6d75b5b
Compare
michaelfig
left a comment
There was a problem hiding this comment.
Please address comments, but otherwise this LGTM!
docs/env.md
Outdated
|
|
||
| ## LOCKDOWN_* | ||
|
|
||
| For the envoronment variables beginning with `LOCKDOWN_` , see [`lockdown` Options](https://github.com/endojs/endo/blob/master/packages/ses/docs/lockdown.md). |
There was a problem hiding this comment.
| For the envoronment variables beginning with `LOCKDOWN_` , see [`lockdown` Options](https://github.com/endojs/endo/blob/master/packages/ses/docs/lockdown.md). | |
| For the environment variables beginning with `LOCKDOWN_` , see [`lockdown` Options](https://github.com/endojs/endo/blob/master/packages/ses/docs/lockdown.md). |
packages/solo/src/start.js
Outdated
| } else if (DEBUG_LIST.includes('agoric:info')) { | ||
| verbosity = ['-v']; | ||
| } else { | ||
| verbosity = []; |
There was a problem hiding this comment.
I overlooked changing this. Please update:
| } else if (DEBUG_LIST.includes('agoric:info')) { | |
| verbosity = ['-v']; | |
| } else { | |
| verbosity = []; | |
| } else if (DEBUG_LIST.includes('agoric:info') || process.env.DEBUG='') { | |
| verbosity = []; | |
| } else { | |
| verbosity = ['-v']; |
closes: #8096
Updates agoric-sdk to use the new conveniences exported by @endo/env-options.
Reform the contents of the
DEBUGenvironment variable, i.e., theprocess.env.DEBUGoption to be a better behaved list foragoric:*options. See the new docs/env.md for details.NOTE: This reform of the meaning of the
agoric:*members of theDEBUGlist is in theory a compat issue. But because we have no known occurrences of that, and it would only affect debugging and logging behavior anyway, we do not flag this PR as a breaking change.