Closed
Conversation
turadg
force-pushed
the
1488-Endo-Passable
branch
from
854ed91 to
55fb2fa
Compare
Deploying agoric-sdk with
|
| Latest commit: |
5b43819
|
| Status: | 🚫 Build failed. |
turadg
force-pushed
the
1488-Endo-Passable
branch
4 times, most recently
from
98dd81a to
7acec08
Compare
turadg
force-pushed
the
1488-Endo-Passable
branch
3 times, most recently
from
9694a37 to
d52b5fd
Compare
dckc
reviewed
Apr 29, 2024
Member
dckc
left a comment
dckc
left a comment
There was a problem hiding this comment.
hope to discuss my comments so far
Comment on lines
279
to
283
| * @param {Promise<Installation>} installationP | ||
| * @param {IssuerKeywordRecord} uncleanIssuerKeywordRecord | ||
| * @param {unknown} customTerms | ||
| * @param {unknown} privateArgs | ||
| * @param {string} instanceLabel |
Member
There was a problem hiding this comment.
in my work-in-progress docs branch, I used @type ZoeService['startInstance'] here, I think
Comment on lines
+217
to
+209
| * @returns {B extends Brand<'nat'> | ||
| * ? NatAmount |
Member
There was a problem hiding this comment.
doesn't AmountMath.make(aNatBrand, ['a set value']) falsify this inference?
turadg
added a commit
to endojs/endo
that referenced
this pull request
May 2, 2024
closes: #1488 ## Description Reattempting: - #1933 Again: - Makes `Passable` a generic type instead of `any`. - Defines overloads for `passStyleOf` to return the actual style. - Defines the `Key` in terms of `Passable` - Makes a ton of fixes and suppressions in places that relied on the previous `any`'s ### Security Considerations n/a ### Scaling Considerations n/a ### Documentation Considerations Better types are better documentation. ### Testing Considerations - [ ] Agoric/agoric-sdk#8774 ### Upgrade Considerations These changes may cause type errors downstream. I don't think we should call those breaking change à la semver because they don't affect the runtime.
turadg
force-pushed
the
1488-Endo-Passable
branch
2 times, most recently
from
487fca0 to
18720f3
Compare
Member
Author
|
endojs/endo#2238 merged to master so I updated the Once this is green the next steps are to:
|
turadg
force-pushed
the
1488-Endo-Passable
branch
2 times, most recently
from
08a881d to
e87ed66
Compare
This was referenced May 5, 2024
turadg
added a commit
to endojs/endo
that referenced
this pull request
May 7, 2024
## Description `ScalarKey` is a patterns concept but without a typedef. This defines it. Necessary for Agoric/agoric-sdk#8774 (review) ### Security Considerations no ### Scaling Considerations no ### Documentation Considerations no ### Testing Considerations new tests ### Compatibility Considerations no ### Upgrade Considerations no
mergify bot
added a commit
that referenced
this pull request
May 8, 2024
This brings Agoric in sync with Endo versions endojs/endo#2272 which covers a new `Passable` type and improvements to `pass-style`, `patterns`, and `exo`. This subsumes changes from #8774 necessary for integration.
Member
Author
|
Landed in the sync PR |
mergify bot
added a commit
that referenced
this pull request
May 10, 2024
## Description Follow up to #8774 Fix the Board types ### Security Considerations <!-- Does this change introduce new assumptions or dependencies that, if violated, could introduce security vulnerabilities? How does this PR change the boundaries between mutually-suspicious components? What new authorities are introduced by this change, perhaps by new API calls? --> ### Scaling Considerations <!-- Does this change require or encourage significant increase in consumption of CPU cycles, RAM, on-chain storage, message exchanges, or other scarce resources? If so, can that be prevented or mitigated? --> ### Documentation Considerations <!-- Give our docs folks some hints about what needs to be described to downstream users. Backwards compatibility: what happens to existing data or deployments when this code is shipped? Do we need to instruct users to do something to upgrade their saved data? If there is no upgrade path possible, how bad will that be for users? --> ### Testing Considerations <!-- Every PR should of course come with tests of its own functionality. What additional tests are still needed beyond those unit tests? How does this affect CI, other test automation, or the testnet? --> ### Upgrade Considerations The one behavior change is to omit non-remotables from the board, but nothing should have been doing that and if it was this error will help. Of course that doesn't need to go out in any particular chain upgrade, but it could to minimize divergence from master until, - #9252
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#endo-branch: master
refs: #1488
Description
Adapt to actual Passable type
Reviewers, the bar as yet is not whether to merge to this repo. This PR is to serve as evidence that endojs/endo#2238 can merge and release and agoric-sdk can quickly adopt the new Endo packages.
Once the required Endo code is available by NPM,
#endo-branchpragmaSecurity Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
To test locally,
Upgrade Considerations